Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assimp 4.1.0 update and glTF support #458

Closed
wants to merge 2 commits into from

Conversation

@tebjan
Copy link
Contributor

tebjan commented May 23, 2019

Description

Related Issue

glTF importer: #96
the "Nothing to Import" issue is still present and not in scope of this PR: #440 and #336

Motivation and Context

loading models in new glTF and STL formats

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@profan

This comment has been minimized.

Copy link
Contributor

profan commented May 23, 2019

Does this handle the PBR material stuff in gltf and set that up on the xenko end at all or is that part of assimps interface and already magically works since xenko had hooked into it earlier? 🤔

I'd test it and see (but I won't be near a computer for a week) but I'm mostly curious as that's one of the biggest advantages of gltf, if not we can always make it the next step 👀👍

Nice either way!

@xen2 xen2 closed this in abef0e8 May 27, 2019
@xen2

This comment has been minimized.

Copy link
Member

xen2 commented May 27, 2019

@profan Nothing changed for materials, some additional work needed in this area.
@tebjan Thanks! Merged, along with some additional testing/error reporting. User should now have a much better idea has an idea of what went wrong rather than cryptic NullReferenceException as reported in #440 and #336.

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented May 27, 2019

good to hear that errors are now shown in a better way. thanks!

@tebjan tebjan deleted the vvvv:assimp-4.1.0-update branch May 27, 2019
@xen2 xen2 mentioned this pull request Jun 5, 2019
xen2 added a commit that referenced this pull request Jun 8, 2019
…ces in projects (closes #458)"

This reverts commit abef0e8.
xen2 added a commit that referenced this pull request Aug 1, 2019
DaveTheGameDev added a commit to DaveTheGameDev/xenko that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.