Fix tests for l23network #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes an update to rspec-puppet ~> 2.2 and adjusting the two tests that fail under 2.2 but not 2.1. I believe these failures are related to rodjek/rspec-puppet#266 The get_network_role_properly was previously passing because the return value was not be properly check. In the code we are returning eth0 as the interface for the admin network role and not nil. The get_transformation_property was previously passing because the return value was not correctly checked. Based on the code, the value for eth2 should have been 1024 while the value for eth3 would have been nil. This change updates the eth2 check with 1024 and adds a test case for eth3. FUEL-Change-Id: I7b87d02d4c702dde68ecd7f4abcd304e686fa795 FUEL-Closes-Bug: #1509056 Close: #182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes an update to rspec-puppet ~> 2.2 and adjusting the
two tests that fail under 2.2 but not 2.1. I believe these failures are
related to rodjek/rspec-puppet#266
The get_network_role_properly was previously passing because the return
value was not be properly check. In the code we are returning eth0 as
the interface for the admin network role and not nil.
The get_transformation_property was previously passing because the
return value was not correctly checked. Based on the code, the value for
eth2 should have been 1024 while the value for eth3 would have been nil.
This change updates the eth2 check with 1024 and adds a test case for
eth3.
FUEL-Change-Id: I7b87d02d4c702dde68ecd7f4abcd304e686fa795
FUEL-Closes-Bug: #1509056
Close: #182