From 5703f1cf8a2803d8b865b230e96bde62d04de008 Mon Sep 17 00:00:00 2001 From: Caleb Cushing Date: Fri, 23 Feb 2024 17:10:21 -0500 Subject: [PATCH] test: improve assertj usage recommendtion from https://github.com/assertj/assertj/issues/3372 --- .../xenoterracide/gradle/semver/SemverExtensionTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/com/xenoterracide/gradle/semver/SemverExtensionTest.java b/src/test/java/com/xenoterracide/gradle/semver/SemverExtensionTest.java index 77b7d0d..9f2083f 100644 --- a/src/test/java/com/xenoterracide/gradle/semver/SemverExtensionTest.java +++ b/src/test/java/com/xenoterracide/gradle/semver/SemverExtensionTest.java @@ -8,6 +8,7 @@ import java.io.File; import java.util.Collections; import java.util.List; +import org.assertj.core.api.InstanceOfAssertFactories; import org.eclipse.jgit.annotations.NonNull; import org.eclipse.jgit.api.Git; import org.junit.jupiter.api.Test; @@ -41,10 +42,9 @@ void getVersion() throws Exception { assertThat(v010) .extracting(Semver::getVersion, Semver::toString) .allSatisfy(o -> { - assertThat(o).isInstanceOf(String.class); - if (o instanceof String s) { - assertThat(s).matches("^0\\.1\\.0-SNAPSHOT-1-g\\p{XDigit}{7}$"); - } + assertThat(o) + .asInstanceOf(InstanceOfAssertFactories.STRING) + .matches("^0\\.1\\.0-SNAPSHOT-1-g\\p{XDigit}{7}$"); }); git.tag().setName("v0.1.1").call();