Skip to content

Replace @VERSION@ with a proper version before calling spectool #17

Merged
merged 1 commit into from Oct 23, 2013

4 participants

@freddy77

spectool internally calls rpm. Newer rpm does more checks on spec file
including checking that version make sense so it does not accept anymore
'@' in version.
Patch version file while sending to spectool.
spectool should not be patched as is a tools copied from another package.

Signed-off-by: Frediano Ziglio frediano.ziglio@citrix.com

@freddy77 freddy77 Replace @VERSION@ with a proper version before calling spectool
spectool internally calls rpm. Newer rpm does more checks on spec file
including checking that version make sense so it does not accept anymore
'@' in version.
Patch version file while sending to spectool.
spectool should not be patched as is a tools copied from another package.

Signed-off-by: Frediano Ziglio <frediano.ziglio@citrix.com>
424ed81
@xen-git
xen-git commented Oct 22, 2013

Can one of the admins verify this patch for testing?

@thomassa

ok to test

@freddy77

I tested under trunk-ring0 and ea-1173exp branches. At least they build.

@jonludlam
XenServer member

Looks like it built OK. Merging!

@jonludlam jonludlam merged commit 103e90e into xenserver:master Oct 23, 2013

1 check passed

Details default Merged build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.