Replace @VERSION@ with a proper version before calling spectool #17

Merged
merged 1 commit into from Oct 23, 2013

Conversation

Projects
None yet
4 participants
@freddy77
Contributor

freddy77 commented Oct 22, 2013

spectool internally calls rpm. Newer rpm does more checks on spec file
including checking that version make sense so it does not accept anymore
'@' in version.
Patch version file while sending to spectool.
spectool should not be patched as is a tools copied from another package.

Signed-off-by: Frediano Ziglio frediano.ziglio@citrix.com

Replace @VERSION@ with a proper version before calling spectool
spectool internally calls rpm. Newer rpm does more checks on spec file
including checking that version make sense so it does not accept anymore
'@' in version.
Patch version file while sending to spectool.
spectool should not be patched as is a tools copied from another package.

Signed-off-by: Frediano Ziglio <frediano.ziglio@citrix.com>
@xen-git

This comment has been minimized.

Show comment
Hide comment
@xen-git

xen-git Oct 22, 2013

Can one of the admins verify this patch for testing?

xen-git commented Oct 22, 2013

Can one of the admins verify this patch for testing?

@thomassa

This comment has been minimized.

Show comment
Hide comment
@thomassa

thomassa Oct 22, 2013

ok to test

ok to test

@freddy77

This comment has been minimized.

Show comment
Hide comment
@freddy77

freddy77 Oct 22, 2013

Contributor

I tested under trunk-ring0 and ea-1173exp branches. At least they build.

Contributor

freddy77 commented Oct 22, 2013

I tested under trunk-ring0 and ea-1173exp branches. At least they build.

@jonludlam

This comment has been minimized.

Show comment
Hide comment
@jonludlam

jonludlam Oct 23, 2013

Member

Looks like it built OK. Merging!

Member

jonludlam commented Oct 23, 2013

Looks like it built OK. Merging!

jonludlam added a commit that referenced this pull request Oct 23, 2013

Merge pull request #17 from freddy77/spectool_version_workaround
Replace @VERSION@ with a proper version before calling spectool

@jonludlam jonludlam merged commit 103e90e into xenserver:master Oct 23, 2013

1 check passed

default Merged build finished.
Details

jonludlam pushed a commit to jonludlam/planex that referenced this pull request Oct 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment