Add compile android arm native lib #188

Closed
wants to merge 4 commits into
from

Projects

READY in sqlite-jdbc-3.16.1

2 participants

@psini
Contributor
psini commented Dec 30, 2016

This pull add the compile of sqlitejdbc for android arm.
Thank you

@@ -98,6 +98,9 @@ $(NATIVE_DLL): $(SQLITE_OUT)/$(LIBNAME)
@mkdir -p $(NATIVE_TARGET_DIR)
cp $< $(NATIVE_TARGET_DIR)/$(LIBNAME)
+android-arm: $(SQLITE_UNPACKED) jni-header
+ ./docker/dockcross-android bash -c 'make clean-native native CROSS_PREFIX=/usr/arm-linux-androideabi/bin/arm-linux-androideabi- OS_NAME=Android OS_ARCH=arm'
@xerial
xerial Dec 31, 2016 Owner

A concern here is OS_NAME (Android) should match JVM system property os.name of DalvikVM for Android.

@xerial
Owner
xerial commented Dec 31, 2016

To check the system is android or not, we need to run System.getProperty("java.runtime.name", "").toLowerCase().contains("android") within OSInfo.java

@xerial
Owner
xerial commented Dec 31, 2016

@psini If you can fix OSInfo.java to add support for android OS, it would be great. But if you can wait for a week, I can do it on behalf of you.

@psini
Contributor
psini commented Dec 31, 2016
@psini
Contributor
psini commented Dec 31, 2016

Done make me know if i have to do other change

@@ -162,6 +162,9 @@ else if (osName.contains("Linux")) {
else if (osName.contains("AIX")) {
return "AIX";
}
+ else if (osName.contains("Android")) {
@xerial
xerial Jan 4, 2017 Owner

@psini Did you check the actual value of os.name JVM property under Android?
I think it's just Linux, so this code wouldn't work as expected

@xerial
Owner
xerial commented Jan 6, 2017

I made changes in #193. Let me close this PR. Thanks.

@xerial xerial closed this Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment