New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol.parseTargetHostAndSlot() is IPV4 oriented #982
Comments
Probably in more places than I know. But yes, fix 'em all. Perhaps a utility function should be made that given a host and port string returns the two pieces. Then replaces all those references with the utility function. |
Sketchy code !!! Without looking at the current HostAndPort !!!!!! class HostAndPort { |
Closed by #1342 |
The code which splits the host part from the port part is very IPV4 oriented and thus it just splits on a
:
. To handle IPV6 cases it should be something like:Since IPV6 uses colons to separate the parts and Jedis uses a colon to separate host from port, using the index of the last colon will select the host-port divider whether it's IPV4 or IPV6.
The text was updated successfully, but these errors were encountered: