New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to set password in JedisCluster #1269

Merged
merged 2 commits into from May 31, 2016

Conversation

Projects
None yet
7 participants
@marcosnils
Collaborator

marcosnils commented Apr 26, 2016

Even though the Redis Cluster spec doesn't say anything about it and the redis community still hasn't agreed about how to handle it, seems like many Redis / Jedis users need this functionality.

I've implemented a very basic (I didn't add the parameter in all the possible constructor combinations) approach by just forwarding the password parameter to the inner JedisPool and discovery instances.

@marcosnils

This comment has been minimized.

Show comment
Hide comment
@marcosnils

marcosnils Apr 26, 2016

Collaborator

@HeartSaVioR plz review.

Collaborator

marcosnils commented Apr 26, 2016

@HeartSaVioR plz review.

@charpty

This comment has been minimized.

Show comment
Hide comment
@charpty

charpty May 22, 2016

@HeartSaVioR Please review and merge this, we really need this feature.
Accuratlly, many coders need this feature.
Thanks!!!

charpty commented May 22, 2016

@HeartSaVioR Please review and merge this, we really need this feature.
Accuratlly, many coders need this feature.
Thanks!!!

@marcosnils

This comment has been minimized.

Show comment
Hide comment
@marcosnils

marcosnils May 22, 2016

Collaborator

@charpty if you need this urgenly you can always merge the PR and provide feedback

Collaborator

marcosnils commented May 22, 2016

@charpty if you need this urgenly you can always merge the PR and provide feedback

1 similar comment
@marcosnils

This comment has been minimized.

Show comment
Hide comment
@marcosnils

marcosnils May 22, 2016

Collaborator

@charpty if you need this urgenly you can always merge the PR and provide feedback

Collaborator

marcosnils commented May 22, 2016

@charpty if you need this urgenly you can always merge the PR and provide feedback

@HeartSaVioR

This comment has been minimized.

Show comment
Hide comment
@HeartSaVioR

HeartSaVioR May 31, 2016

Collaborator

Sorry it's been a long time far from this issue. LGTM.
@marcosnils Thanks for the great work!

Collaborator

HeartSaVioR commented May 31, 2016

Sorry it's been a long time far from this issue. LGTM.
@marcosnils Thanks for the great work!

@HeartSaVioR HeartSaVioR merged commit 6a9359f into master May 31, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@HeartSaVioR HeartSaVioR modified the milestones: 2.8.2, 2.9.0 May 31, 2016

@HeartSaVioR

This comment has been minimized.

Show comment
Hide comment
@HeartSaVioR

HeartSaVioR May 31, 2016

Collaborator

Resetting the milestone to 2.9.0 since it's not a bug, but just a new feature which is support for Azure environment.

@marcosnils Please reset milestone to 2.8.2 and backport if you think we need to ship this to bugfix release. Thanks!

Collaborator

HeartSaVioR commented May 31, 2016

Resetting the milestone to 2.9.0 since it's not a bug, but just a new feature which is support for Azure environment.

@marcosnils Please reset milestone to 2.8.2 and backport if you think we need to ship this to bugfix release. Thanks!

HeartSaVioR added a commit that referenced this pull request May 31, 2016

Add support to set password in JedisCluster (#1269)
* Remove unnecessary cluster node

* Add support to set password in JedisCluster

Fixes #1242
Fixes #1268
@HeartSaVioR

This comment has been minimized.

Show comment
Hide comment
@HeartSaVioR

HeartSaVioR May 31, 2016

Collaborator

I merged into master and 2.9 branch. Thanks!

Collaborator

HeartSaVioR commented May 31, 2016

I merged into master and 2.9 branch. Thanks!

@marcosnils

This comment has been minimized.

Show comment
Hide comment
@marcosnils

marcosnils May 31, 2016

Collaborator

@HeartSaVioR It's ok, we can include it in 2.9.

Thx for merging!.

Collaborator

marcosnils commented May 31, 2016

@HeartSaVioR It's ok, we can include it in 2.9.

Thx for merging!.

@alexs20

This comment has been minimized.

Show comment
Hide comment
@alexs20

alexs20 Jun 21, 2016

When do you plan to release 2.9?
We need the cluster password functionality... thanks.

alexs20 commented Jun 21, 2016

When do you plan to release 2.9?
We need the cluster password functionality... thanks.

@PunKeel

This comment has been minimized.

Show comment
Hide comment
@PunKeel

PunKeel Jun 23, 2016

+1 alexs20

PunKeel commented Jun 23, 2016

+1 alexs20

@marcosnils

This comment has been minimized.

Show comment
Hide comment
@marcosnils

marcosnils Jun 23, 2016

Collaborator

@alexs20 @PunKeel we have some PR's and issues we need to work on before releasing 2.9. Unfortunately we can't commit to a date for the moment, but if you need this urgently you can always build Jedis from source.

Collaborator

marcosnils commented Jun 23, 2016

@alexs20 @PunKeel we have some PR's and issues we need to work on before releasing 2.9. Unfortunately we can't commit to a date for the moment, but if you need this urgently you can always build Jedis from source.

@PunKeel

This comment has been minimized.

Show comment
Hide comment
@PunKeel

PunKeel Jun 23, 2016

@marcosnils Thanks & no issue on this side for me, just didn't want to use an unstable API ;-)

PunKeel commented Jun 23, 2016

@marcosnils Thanks & no issue on this side for me, just didn't want to use an unstable API ;-)

@marcosnils

This comment has been minimized.

Show comment
Hide comment
@marcosnils

marcosnils Jun 23, 2016

Collaborator

@PunKeel all jedis official branches (master / 2.9 and 2.8) are fully tested and stable. We usually hold releases for sometime because we try to include all opened issues.

Collaborator

marcosnils commented Jun 23, 2016

@PunKeel all jedis official branches (master / 2.9 and 2.8) are fully tested and stable. We usually hold releases for sometime because we try to include all opened issues.

@alexs20

This comment has been minimized.

Show comment
Hide comment
@alexs20

alexs20 Jun 23, 2016

@marcosnils Sure we can. And I personally done. And it works perfect. But unfortunately our company policy against using SNAPSHOT jars in production environment. Fortunately we have a couple month before release, but if the delay will be too long then we have no choice but to search for alternative solutions. I just need a raw ETA like month, two, three, just to report something to my boss.

alexs20 commented Jun 23, 2016

@marcosnils Sure we can. And I personally done. And it works perfect. But unfortunately our company policy against using SNAPSHOT jars in production environment. Fortunately we have a couple month before release, but if the delay will be too long then we have no choice but to search for alternative solutions. I just need a raw ETA like month, two, three, just to report something to my boss.

@qqj1979

This comment has been minimized.

Show comment
Hide comment
@qqj1979

qqj1979 Jun 29, 2016

waiting for jedis official branches 2.9 .

qqj1979 commented Jun 29, 2016

waiting for jedis official branches 2.9 .

@liuwenru

This comment has been minimized.

Show comment
Hide comment
@liuwenru

liuwenru Mar 25, 2017

how can i connect redis cluster with password, can give some example or write to the wiki,
for following method,can you help me ,tell us what the mean of soTimeout

public JedisCluster(Set<HostAndPort> jedisClusterNode,
                    int connectionTimeout,
                    int soTimeout,
                    int maxRedirections,
                    org.apache.commons.pool2.impl.GenericObjectPoolConfig poolConfig)

liuwenru commented Mar 25, 2017

how can i connect redis cluster with password, can give some example or write to the wiki,
for following method,can you help me ,tell us what the mean of soTimeout

public JedisCluster(Set<HostAndPort> jedisClusterNode,
                    int connectionTimeout,
                    int soTimeout,
                    int maxRedirections,
                    org.apache.commons.pool2.impl.GenericObjectPoolConfig poolConfig)
@alexs20

This comment has been minimized.

Show comment
Hide comment
@alexs20

alexs20 Mar 25, 2017

@liuwenru, use this constructor:
JedisCluster(HostAndPort node, int connectionTimeout, int soTimeout,
int maxAttempts, String password, final GenericObjectPoolConfig poolConfig)

soTimeout is a socket read timeout

alexs20 commented Mar 25, 2017

@liuwenru, use this constructor:
JedisCluster(HostAndPort node, int connectionTimeout, int soTimeout,
int maxAttempts, String password, final GenericObjectPoolConfig poolConfig)

soTimeout is a socket read timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment