Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure a Sentinel Connection when initialising the Sentinel pool #1943

Merged
merged 5 commits into from Nov 26, 2019

Conversation

@karltinawi
Copy link
Contributor

karltinawi commented Jan 28, 2019

This commit attempts to solve #1487 and #1636.

This PR adds a constructor to JedisSentinelPool to configure a Sentinel connection with respective timeout settings and a password. Supporting constructors have also been added to BinaryJedis and Jedis classes.

Thanks in advance for your review.

Added a constructor to JedisSentinelPool to configure a Sentinel
connection with respective timeout settings and a password.
@karltinawi karltinawi changed the title Configure a Sentinel Connection when initialising the pool (#1487 and #1636) Configure a Sentinel Connection when initialising the Sentinel pool Jan 28, 2019
Karl Tinawi
- Removed the default password variable
- Always initialise Jedis with password (null password is ignored)
- Move sentinal parameters after client parameters
Karl Tinawi
- Added constructor to allow 'sentinelClientName'.
- Use auth() and clientSetName() when creating Jedis to connect to sentinel
- Removed newly added constructors from Jedis and BinaryJedis
Karl Tinawi
- Removed constructor the defaults sentinelClientName to 'null'.
- Resolved 'tab' indentation
- Moved all sentinel instance variables after 'master' variables.
@sazzad16 sazzad16 added this to the 3.1.0 milestone Jan 30, 2019
@karltinawi

This comment has been minimized.

Copy link
Contributor Author

karltinawi commented Jan 30, 2019

Thanks @sazzad16.

protected String password;

protected int database = Protocol.DEFAULT_DATABASE;
protected int database;

This comment has been minimized.

Copy link
@gkorland

gkorland Jul 14, 2019

Collaborator

final?


protected String clientName;

protected int sentinelConnectionTimeout;
protected int sentinelSoTimeout;

This comment has been minimized.

Copy link
@gkorland

gkorland Jul 14, 2019

Collaborator

should all these fields be final?

@sazzad16 sazzad16 modified the milestones: 3.1.0, 3.2.0 Jul 17, 2019
@silentFred

This comment has been minimized.

Copy link

silentFred commented Sep 19, 2019

What is the holdup on this PR? Would be great to have this sometime

@sazzad16 sazzad16 merged commit 6b86fe7 into xetorthio:master Nov 26, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.