Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented zpopmax, zpopmax with count #1968

Merged
merged 5 commits into from Dec 9, 2019
Merged

implemented zpopmax, zpopmax with count #1968

merged 5 commits into from Dec 9, 2019

Conversation

@z0mg
Copy link
Contributor

z0mg commented Apr 10, 2019

Added tests under redis.clients.jedis.tests.commands.SortedSetCommandsTest.
Tried mimicking other binary asserts, but it looks like you can use any value for expected.add(SafeEncoder.encode("x"));, they'll all pass.

src/main/java/redis/clients/jedis/Jedis.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/Jedis.java Outdated Show resolved Hide resolved
@z0mg

This comment has been minimized.

Copy link
Contributor Author

z0mg commented Apr 22, 2019

Have a look, please.

@sazzad16

This comment has been minimized.

Copy link
Collaborator

sazzad16 commented Apr 22, 2019

LGTM!

@sazzad16 sazzad16 added this to the 3.1.0 milestone Apr 22, 2019
@sazzad16 sazzad16 mentioned this pull request Jun 4, 2019
@sazzad16 sazzad16 requested a review from gkorland Jul 6, 2019
@gkorland gkorland modified the milestones: 3.1.0, 3.2.0 Jul 14, 2019
@guptaaditya13

This comment has been minimized.

Copy link

guptaaditya13 commented Sep 17, 2019

Any ETA on when this will be merged? @gkorland

@@ -285,6 +285,24 @@ public String toString() {

};

public static final Builder<Tuple> TUPLE = new Builder<Tuple>() {

This comment has been minimized.

Copy link
@gkorland

gkorland Oct 15, 2019

Collaborator

@z0mg can you please add a comment about the different between TUPLE_ZSET and TUPLE?
Or perhaps we better even rename this builder?

This comment has been minimized.

Copy link
@sazzad16

sazzad16 Oct 16, 2019

Collaborator

@gkorland ZPOPMAX and ZPOPMIN without count returns only one Tuple. Returning a Tuple should be better instead of returning a Set of single Tuple. This builder helps on that purpose.

sazzad16 added a commit to sazzad16/jedis that referenced this pull request Oct 16, 2019
@sazzad16 sazzad16 force-pushed the z0mg:zpopmax branch from f7da428 to 4926abc Oct 28, 2019
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Nov 25, 2019
@sazzad16 sazzad16 force-pushed the z0mg:zpopmax branch from a534c70 to 915a810 Nov 25, 2019
@sazzad16 sazzad16 merged commit 5089cbd into xetorthio:master Dec 9, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Dec 9, 2019
@sazzad16 sazzad16 removed the READY TO MERGE label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.