Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl zpopmin command #1988

Merged
merged 11 commits into from Oct 16, 2019
Merged

Impl zpopmin command #1988

merged 11 commits into from Oct 16, 2019

Conversation

@kommradHomer
Copy link
Contributor

kommradHomer commented Jun 6, 2019

implemented zpopmin command.
written a test method

pom.xml Outdated Show resolved Hide resolved
@kommradHomer

This comment has been minimized.

Copy link
Contributor Author

kommradHomer commented Jun 13, 2019

removed the unnecessary plugin

Copy link
Collaborator

sazzad16 left a comment

Please remove only whitespace changes.

Also, it would be helpful if you could remove continuous empty lines from your code.

pom.xml Outdated Show resolved Hide resolved
@sazzad16 sazzad16 added this to the 3.1.0 milestone Jun 20, 2019
@sazzad16 sazzad16 requested a review from gkorland Jul 6, 2019
@gkorland

This comment has been minimized.

Copy link
Collaborator

gkorland commented Jul 7, 2019

what about JedisClusterCommands?

@gkorland gkorland modified the milestones: 3.1.0, 3.2.0 Jul 14, 2019
@gkorland gkorland requested a review from sazzad16 Oct 15, 2019
sazzad16 added 4 commits Oct 16, 2019
@sazzad16 sazzad16 merged commit db338f1 into xetorthio:master Oct 16, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Oct 16, 2019
@SuShuilian

This comment has been minimized.

Copy link

SuShuilian commented Oct 18, 2019

I am looking forward to seeing this new command available in release version.
When will it be available in release version, any plan?

sazzad16 added a commit to sazzad16/jedis that referenced this pull request Oct 28, 2019
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Nov 25, 2019
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Nov 25, 2019
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Dec 9, 2019
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.