Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions on close in JedisSentinelPool #2102

Merged
merged 1 commit into from Nov 24, 2019

Conversation

@Talon876
Copy link
Contributor

Talon876 commented Nov 22, 2019

When returning a Jedis object to the pool, handle any exceptions and still return the connection to prevent deadlock.
This is similar to issue and fix for #791, but for the JedisSentinelPool.

When returning a Jedis object to the pool, handle any exceptions and still
return the connection to prevent deadlock.
This is similar to issue #791 but for the JedisSentinelPool.
@Talon876 Talon876 changed the title Handle exceptions on close Handle exceptions on close in JedisSentinelPool Nov 22, 2019
@sazzad16

This comment has been minimized.

Copy link
Collaborator

sazzad16 commented Nov 22, 2019

LGTM!

@sazzad16 sazzad16 added this to the 3.2.0 milestone Nov 22, 2019
@gkorland gkorland requested review from sazzad16 and gkorland Nov 23, 2019
@sazzad16 sazzad16 merged commit a64bb5d into xetorthio:master Nov 24, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.