Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pull request #245

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

Hi,

please, pull the changes I include. They're basically done to provide support for Unix Domain Sockets (Issue 144). I extended the Jedis class (I thought that was the easiest way to avoid modifying the API).

I also added test for other tickets which were already solved, I think it's good practice to create tests for the bugs already fixed.

Any problem you might have just let me know and I will try to solve it as soon as possible, I am github and I do not discard having made some mistake.

BTW. I'd like to collaborate with you more actively

unknown added some commits Dec 22, 2011

new file: bin/libjunixsocket-linux-1.5-amd64.so
	new file:   bin/libjunixsocket-linux-1.5-i386.so
	new file:   bin/libjunixsocket-macosx-1.5-i386.dylib
	new file:   bin/libjunixsocket-macosx-1.5-x86_64.dylib
	modified:   conf/redis.conf
modified:   conf/redis2.conf
	new file:   jdk-6u29-linux-i586.bin
	new file:   junixsocket-1.3/LICENSE.txt
	new file:   junixsocket-1.3/README.txt
	new file:   junixsocket-1.3/dist/junixsocket-1.3.jar
	new file:   junixsocket-1.3/dist/junixsocket-demo-1.3.jar
	new file:   junixsocket-1.3/dist/junixsocket-mysql-1.3.jar
	new file:   junixsocket-1.3/dist/junixsocket-rmi-1.3.jar
	new file:   junixsocket-1.3/lib-native/libjunixsocket-linux-1.5-amd64.so
	new file:   junixsocket-1.3/lib-native/libjunixsocket-linux-1.5-i386.so
	new file:   junixsocket-1.3/lib-native/libjunixsocket-macosx-1.5-i386.dylib
	new file:   junixsocket-1.3/lib-native/libjunixsocket-macosx-1.5-x86_64.dylib
	new file:   lib/junixsocket-1.3.jar
	modified:   pom.xml

	modified:   src/main/java/redis/clients/jedis/BinaryClient.java
	modified:   src/main/java/redis/clients/jedis/BinaryJedis.java
	modified:   src/main/java/redis/clients/jedis/Client.java
	modified:   src/main/java/redis/clients/jedis/Connection.java
	modified:   src/main/java/redis/clients/jedis/Jedis.java
	new file:   src/main/java/redis/clients/jedis/unix/UnixDomainJedis.java
	new file:   src/test/java/redis/clients/jedis/tests/commands/ResponseTest.java
	new file:   src/test/java/redis/clients/jedis/tests/unix/UnixDomainJedisTest.java
Owner

xetorthio commented Dec 25, 2011

I wonder if we need a different class for this.
Can't we make it in such a way that if you provide a File it sets itself to uso unix socket?

Hi,

you're right, we don't need strictly a class for that. But since most times the Unix Socket won't be used, I preferred to put it split just to avoid the risk of someone using it and getting the annoying "NoClassDefFoundError" or even worse getting errors from de JNI libraries that could not be found (because that person do not need it).

However, it is just another way ;)

Hi,

are you going to pull the changes I did? Do you need some extra changes?

Owner

xetorthio commented Jul 16, 2012

It will be marged probably. I'm still thinking which is the best way to go, if a single class or several classes.

Hi guys,

@xetorthio: is any progress on this issue?

@nachogiljaldo: have you done any production tests of your code?

Collaborator

HeartSaVioR commented Apr 24, 2014

I think we should avoid dependencies, so we need to separate layers into socket layer and client layer if we really think Jedis needs it.

Unfortunately, it is not that simple.
Please see #492 (comment) .

Collaborator

HeartSaVioR commented May 31, 2015

I don't believe we can apply it now, cause we don't plan to separate layers.
If you think we really need it, please leave a comment. Closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment