Skip to content

RedisInputStream#readLine can't decode multi-byte characters. #320

Closed
wants to merge 1 commit into from

3 participants

@masayuki038

Since RedisInputStream#readLine can't decode multi-byte characters, changing the way to decode from byte[] to string.

@xetorthio
Owner

Oh great! this is amazing! So this fixes using multi-byte strings with redis and jedis?

@masayuki038

Oh great! this is amazing! So this fixes using multi-byte strings with redis and jedis?

No. Since this method is called to read first line of a response only, this change do not affect to read a response at this time. But there are some problems for reading/writing multi-bytes strings, tell me those and I will check. thanks.

@HeartSaVioR
Collaborator

Now RedisInputStream.readLine() is used for only reading error line.
Since we don't receive reports regarding this, I feel it doesn't really matter.
Please comment if you meet any issues regarding this.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.