New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jedis pool return jedis pooled connection object. #345

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mpillar

mpillar commented Sep 15, 2012

And some small build changes.

mpillar added some commits Sep 14, 2012

Make jedis pool return jedis pooled connection object.
This allows us to call returnResource() on the connection object as
opposed to having to pass the pool around for the return. JDBC style,
just a little more explicit.
@fbettag

This comment has been minimized.

fbettag commented Dec 15, 2012

This is very nice and also fixes an issue where returnResource() is an ambiguous reference.

[error]  ambiguous reference to overloaded definition,
[error] both method returnResource in class JedisPool of type (x$1: redis.clients.jedis.BinaryJedis)Unit
[error] and  method returnResource in class Pool of type (x$1: redis.clients.jedis.Jedis)Unit
[error] match argument types (redis.clients.jedis.Jedis)
[error]     pool.returnResource(jedis: Jedis)
@deserat

This comment has been minimized.

deserat commented Jan 11, 2014

Having the issue mentioned by @fbettag it's related to scala. anybody know a work around?

@HeartSaVioR

This comment has been minimized.

Collaborator

HeartSaVioR commented May 31, 2015

There're too much changes on Jedis so I don't think I can apply this now.
Closing.

ps. ambiguous reference to overloaded definition issue should be reported to another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment