Skip to content
Browse files

Fix outdoor pvp quests completion

  • Loading branch information...
1 parent 45c2a33 commit eabe0f060c6c75dcab82c3fe015a542ddfacd4b5 @xfurry committed Mar 24, 2012
View
2 src/game/OutdoorPvP/OutdoorPvPEP.cpp
@@ -139,7 +139,7 @@ void OutdoorPvPEP::OnGameObjectCreate(GameObject* pGo)
}
}
-void OutdoorPvPEP::HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team)
+void OutdoorPvPEP::HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team)
{
uint32 uiCredit = 0;
View
2 src/game/OutdoorPvP/OutdoorPvPEP.h
@@ -255,7 +255,7 @@ class OutdoorPvPEP : public OutdoorPvP
void HandlePlayerEnterZone(Player* pPlayer);
void HandlePlayerLeaveZone(Player* pPlayer);
- void HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team);
+ void HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team);
void FillInitialWorldStates(WorldPacket& data, uint32& count);
void SendRemoveWorldStates(Player* pPlayer);
View
2 src/game/OutdoorPvP/OutdoorPvPHP.cpp
@@ -125,7 +125,7 @@ void OutdoorPvPHP::OnGameObjectCreate(GameObject* pGo)
}
}
-void OutdoorPvPHP::HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team)
+void OutdoorPvPHP::HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team)
{
uint32 uiCredit = 0;
View
2 src/game/OutdoorPvP/OutdoorPvPHP.h
@@ -159,7 +159,7 @@ class OutdoorPvPHP : public OutdoorPvP
void HandlePlayerEnterZone(Player* pPlayer);
void HandlePlayerLeaveZone(Player* pPlayer);
- void HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team);
+ void HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team);
void HandlePlayerKillInsideArea(Player* pPlayer, Unit* pVictim);
void FillInitialWorldStates(WorldPacket& data, uint32& count);
View
2 src/game/OutdoorPvP/OutdoorPvPNA.cpp
@@ -81,7 +81,7 @@ void OutdoorPvPNA::HandlePlayerLeaveZone(Player* pPlayer)
OutdoorPvP::HandlePlayerLeaveZone(pPlayer);
}
-void OutdoorPvPNA::HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team)
+void OutdoorPvPNA::HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team)
{
if (uiEventId == EVENT_HALAA_BANNER_WIN_ALLIANCE || uiEventId == EVENT_HALAA_BANNER_WIN_HORDE)
{
View
2 src/game/OutdoorPvP/OutdoorPvPNA.h
@@ -163,7 +163,7 @@ class OutdoorPvPNA : public OutdoorPvP
void HandlePlayerEnterZone(Player* pPlayer);
void HandlePlayerLeaveZone(Player* pPlayer);
- void HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team);
+ void HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team);
void HandlePlayerKillInsideArea(Player* pPlayer, Unit* pVictim);
void OnCreatureCreate(Creature* pCreature);
View
2 src/game/OutdoorPvP/OutdoorPvPTF.cpp
@@ -127,7 +127,7 @@ void OutdoorPvPTF::OnGameObjectCreate(GameObject* pGo)
}
}
-void OutdoorPvPTF::HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team)
+void OutdoorPvPTF::HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team)
{
for (uint8 i = 0; i < MAX_TF_TOWERS; ++i)
{
View
2 src/game/OutdoorPvP/OutdoorPvPTF.h
@@ -171,7 +171,7 @@ class OutdoorPvPTF : public OutdoorPvP
void HandlePlayerEnterZone(Player* pPlayer);
void HandlePlayerLeaveZone(Player* pPlayer);
- void HandleObjectiveComplete(uint32 uiEventId, std::list<Player*> players, Team team);
+ void HandleObjectiveComplete(std::list<Player*> players, uint32 uiEventId, Team team);
void Update(uint32 diff);

1 comment on commit eabe0f0

@stfx
stfx commented on eabe0f0 Mar 24, 2012

afaik I wanted uiEventId to be the first param because thats also how it is used for sd2. So yea it should again be changed but I guess I forgot to do the same for the HandleObjectiveComplete in the HandleObjectiveComplete function of OutdoorPvPMgr.cpp ;)

Please sign in to comment.
Something went wrong with that request. Please try again.