Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle None valid_bits in Boolean algorithms #78

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@xhochy
Copy link
Owner

commented Sep 1, 2019

No description provided.

@xhochy xhochy requested a review from fjetter Sep 1, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 1, 2019

Codecov Report

Merging #78 into master will decrease coverage by 1.89%.
The diff coverage is 52.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #78     +/-   ##
=========================================
- Coverage   89.95%   88.05%   -1.9%     
=========================================
  Files          15       16      +1     
  Lines        1085     1139     +54     
=========================================
+ Hits          976     1003     +27     
- Misses        109      136     +27
Impacted Files Coverage Δ
benchmarks/boolean.py 0% <0%> (ø)
fletcher/base.py 94.16% <100%> (+0.02%) ⬆️
fletcher/_algorithms.py 95.1% <100%> (+0.06%) ⬆️
tests/test_algorithms.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b68f0d...f8bb5dc. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Sep 1, 2019

Codecov Report

Merging #78 into master will decrease coverage by 1.89%.
The diff coverage is 52.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #78     +/-   ##
=========================================
- Coverage   89.95%   88.05%   -1.9%     
=========================================
  Files          15       16      +1     
  Lines        1085     1139     +54     
=========================================
+ Hits          976     1003     +27     
- Misses        109      136     +27
Impacted Files Coverage Δ
benchmarks/boolean.py 0% <0%> (ø)
fletcher/base.py 94.16% <100%> (+0.02%) ⬆️
fletcher/_algorithms.py 95.1% <100%> (+0.06%) ⬆️
tests/test_algorithms.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b68f0d...f8bb5dc. Read the comment docs.

@xhochy

This comment has been minimized.

Copy link
Owner Author

commented Sep 1, 2019

Merging as reviewers are on vacation

@xhochy xhochy merged commit 5bb54ba into master Sep 1, 2019

5 of 7 checks passed

codecov/patch 52.72% of diff hit (target 89.95%)
Details
codecov/project 88.05% (-1.9%) compared to 1b68f0d
Details
License Compliance All checks passed.
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
ci/circleci: upstream-dev Your tests passed on CircleCI!
Details
ci/gitlab/boolean-no-nulls Pipeline passed on GitLab
Details

@xhochy xhochy deleted the boolean-no-nulls branch Sep 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.