Uwe L. Korn
xhochy

Organizations

@tomahawk-player @HaDiNet @hubot-scripts @blue-yonder @CodeforKarlsruhe
Aug 24, 2016
Aug 24, 2016
Aug 23, 2016
xhochy commented on pull request apache/parquet-cpp#143
@xhochy

From reading the parquet-mr code I got at least the impression that the only difference are the used enums, i.e. at least the output of dictionary-…

Aug 23, 2016
xhochy commented on pull request apache/parquet-cpp#142
@xhochy

@wesm @majetideepak as in-source comments are a bit cluttered in github, I'm continuing the discussion about the pages here: I would: Create a…

Aug 23, 2016
xhochy commented on pull request apache/parquet-cpp#142
@xhochy

Also we cannot share the encoder as with DictionaryEncoding, the encoder itself carry state (i.e. the dictionary).

Aug 23, 2016
xhochy commented on pull request apache/parquet-cpp#142
@xhochy

yes, we should.

Aug 6, 2016
xhochy opened pull request apache/parquet-cpp#142
@xhochy
PARQUET-666: Add support for writing dictionaries
1 commit with 314 additions and 165 deletions
Aug 6, 2016
@xhochy
  • @xhochy a3b4043
    PARQUET-666: Add support for writing dictionaries
Aug 6, 2016
Aug 6, 2016
@xhochy
Aug 6, 2016
xhochy commented on pull request apache/arrow#107
@xhochy

This is a convenience option so you can easily write Parquet files with timestamp columns.

Aug 6, 2016
@xhochy
Aug 3, 2016
xhochy commented on pull request apache/arrow#107
@xhochy

oh, I actually did not see that. ups, will have to improve a bit on my code then.

Aug 3, 2016
xhochy commented on pull request apache/arrow#111
@xhochy

Please make the constructor virtual. This is probably not the problem why Travis fails but at least a problem.

Jul 26, 2016
@xhochy
  • @xhochy c3d4953
    Use more realistic default value for timestamps
xhochy created branch arrow-242 at xhochy/arrow
Jul 26, 2016
Jul 24, 2016
xhochy commented on pull request apache/arrow#105
@xhochy

2.8.12.2 also work, probably >2.8.6 is required

Jul 24, 2016
xhochy commented on pull request apache/arrow#105
@xhochy

Minimal GCC is 4.8, working locally and in the manylinux1 docker image. GCC 4.7 is definitely not working as we're using using features implemented…

Jul 14, 2016
xhochy commented on pull request apache/arrow#105
@xhochy

This seems to be mainly our current Travis build baked into the README. While it may be a convenient approach for Travis, I do not recommend it for…

Jul 14, 2016
xhochy commented on pull request apache/arrow#105
@xhochy

Not sure what our current minimal Boost version is but I expect that it would be better to advise to install system-packages instead of doing sudo …

Jul 14, 2016
xhochy commented on pull request apache/arrow#105
@xhochy

These instruction sound very general but probably only apply to old Ubuntu versions, 12.04 is nearly end-of-life and 14.04 already has GCC 4.8 whic…

Jul 13, 2016
xhochy commented on pull request apache/arrow#104
@xhochy

The general approach looks good, +1.

Jul 12, 2016
xhochy commented on pull request apache/arrow#104
@xhochy

See above

Jul 12, 2016
xhochy commented on pull request apache/arrow#104
@xhochy

This should be ARROW_NO_EXPORT?

Jul 11, 2016
xhochy commented on pull request apache/arrow#101
@xhochy

No, I cannot make a problem up (yet). I was just bothered if it could be one. But as long as things work fine, we don't need to have to these macros.

Jul 11, 2016
xhochy commented on pull request apache/arrow#101
@xhochy

I'm actually a bit bothered if it really is a good idea to have the same export macro for different shared libs. Sadly this thought did not come up…

Jul 11, 2016
xhochy commented on pull request apache/arrow#101
@xhochy

+1 for making all these int64_t

Jul 11, 2016
xhochy commented on pull request apache/parquet-cpp#138
@xhochy

+1, LGTM

Jul 10, 2016
xhochy commented on pull request apache/arrow#100
@xhochy

+1, LGTM

Jul 10, 2016
xhochy commented on pull request apache/parquet-cpp#136
@xhochy

Actually discovered this while chasing for PARQUET-659