Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serialization/deserialization optional in xi-rope #1197

Closed
cmyr opened this issue Jun 22, 2019 · 0 comments · Fixed by #1200

Comments

@cmyr
Copy link
Member

commented Jun 22, 2019

As part of making xi more modular, the serde dependency in xi-rope should become optional.

This requires adding a new feature to the Cargo.toml in xi-rope, and putting all the serde imports and definitions behind #[cfg(feature = "serde")] guards.

@cmyr cmyr added this to To do in editor toolkit via automation Jun 22, 2019

Cogitri added a commit to Cogitri/xi-editor that referenced this issue Jun 22, 2019
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Jun 22, 2019
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Jun 23, 2019
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Jun 23, 2019
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Jun 24, 2019
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Jun 27, 2019
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Jun 28, 2019

editor toolkit automation moved this from To do to Done Jun 28, 2019

Cogitri added a commit that referenced this issue Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.