Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Find in core and `search_dialog` RPC command #688
This depends on #687
This pull request implements the
I also added this to xi-mac for testing: https://github.com/scholtzan/xi-mac/tree/async-find
What exactly is the behaviour that changes based when this is sent? Is it entirely related to the rendering of inactive highlights, or are there other changes?
In general I have a preference for RPC names that communicate behaviour, rather than UI state. In other words, if this flag indicates whether a partial find match should be shown, we might want to call it