New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Integrate hugo-easy-gallery and replace fancybox by photoswipe #48

Merged
merged 5 commits into from May 2, 2018

Conversation

Projects
None yet
2 participants
@Zebradil
Collaborator

Zebradil commented Apr 29, 2018

This proposal was preceded by our discussion in #30.

In this PR I completely removed fancybox plugin and integrated photoswipe instead. I'm not sure if it's useful to have settings for choosing source of photoswipe files as it was for fancybox (local, bootcdn, custom CDN). So, I left it as it was in hugo-easy-gallery repo — CloudFlare CDN.

Zebradil added some commits Apr 28, 2018

@Zebradil Zebradil requested a review from xianmin Apr 29, 2018

@xianmin xianmin merged commit cb1016e into xianmin:master May 2, 2018

xianmin added a commit that referenced this pull request May 2, 2018

Merge pull request #48 from Zebradil/master
 Integrate hugo-easy-gallery and replace fancybox by photoswipe
@xianmin

This comment has been minimized.

Owner

xianmin commented May 2, 2018

@Zebradil Thanks for your PR!
There are a few minor problems, I fixed them when I test.

  1. In China, the CDN maybe can not use, so it's better use local file by default.
  2. I change the default config, compatibility both photoswipe & fancybox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment