New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of languages to the menu #79

Merged
merged 4 commits into from Jul 13, 2018

Conversation

Projects
None yet
2 participants
@shaform
Collaborator

shaform commented Jul 12, 2018

First attempt to work towards #32 .

  1. I add a globe icon as the user might not be able to recognize language if he does not understand the language. The icon is in public domain.
  2. I add a showMenuLanguageChooser option to control the display of the menu.
  3. The current language is shown in bold font.

BTW, I did not commit the compiled webpack. I also did not add the language chooser to sildeout.html since it hasn't supported drop down menu yet.

@xianmin

This comment has been minimized.

Owner

xianmin commented Jul 13, 2018

Great job!

Now, I have supported drop down menu in mobile-menu.

Would you please add this feature to sildeout.html ?

@shaform shaform force-pushed the shaform:lang-switch branch from 039fdfd to fe22a0b Jul 13, 2018

@shaform

This comment has been minimized.

Collaborator

shaform commented Jul 13, 2018

@xianmin Updated.

@xianmin xianmin merged commit 38c1e22 into xianmin:master Jul 13, 2018

@shaform shaform deleted the shaform:lang-switch branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment