New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to correct RSS URL, fix #75 #82

Merged
merged 1 commit into from Jul 16, 2018

Conversation

Projects
None yet
2 participants
@shaform
Collaborator

shaform commented Jul 14, 2018

As talked about in #75, current RSS link in multilingual environment is incorrect.
BTW, as I am new to Hugo development, I am not sure whether there is a better syntax than the two withs.

@xianmin

This comment has been minimized.

Owner

xianmin commented Jul 16, 2018

Thanks for your work!

  1. In my productive environment, head.html, {{.Site.Title}} generate error. use {{$.Site.Title}} instead will fix. See Introduction to Hugo Templating | Hugo .
  2. In head.html, should we need {{ with .Site.GetPage "home" -}} ? In previous versions, we don't use home rss link in <head>. If there is no better explanation, I think we needn't change it temporarily.

@shaform shaform force-pushed the shaform:rss branch from 877ebf5 to e17249c Jul 16, 2018

@shaform

This comment has been minimized.

Collaborator

shaform commented Jul 16, 2018

Thanks! You are right. That's a mistake. Fixed.

@xianmin xianmin merged commit b2548bd into xianmin:master Jul 16, 2018

@shaform shaform deleted the shaform:rss branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment