Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for Paper's AsyncChat #20

Open
NoltoxGit opened this issue Jan 22, 2024 · 2 comments
Open

[Feature Request] Add support for Paper's AsyncChat #20

NoltoxGit opened this issue Jan 22, 2024 · 2 comments

Comments

@NoltoxGit
Copy link

Hello,
Can you add the support for the Paper AsyncChatEvent and/or AsyncChatDecorateEvent in the configuration of your plugin please?
Because you're currently using an old listener: org.bukkit.event.player.AsyncPlayerChatEvent.

Example for a new configuration:

# Use Paper's async Chat Event
use-async-chat: true/false

Thank you so much if you add this! :)

@Xiao-MoMi
Copy link
Owner

This might take more resources because we can only get component from paper event. And before parsing it we have to convert it shaded-component and then call methods like
https://github.com/Xiao-MoMi/Custom-Nameplates/blob/main/paper/src/main/java/net/momirealms/customnameplates/paper/mechanic/font/WidthManagerImpl.java#L918
One more question, why do you need the paper event

@NoltoxGit
Copy link
Author

This might take more resources because we can only get component from paper event. And before parsing it we have to convert it shaded-component and then call methods like https://github.com/Xiao-MoMi/Custom-Nameplates/blob/main/paper/src/main/java/net/momirealms/customnameplates/paper/mechanic/font/WidthManagerImpl.java#L918 One more question, why do you need the paper event

Hello,
Yes, I understand;
And why am I asking this? Because one of the plugins I use strongly recommends the use of this event to allow better compatibility. You're not the only plugin I've made this suggestion to, I've made it to a few others too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants