Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Import - Matching existing dataSet does not replace columnId's in the widgets #1499

Closed
PeterMis opened this issue Apr 27, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@PeterMis
Copy link
Member

When we are importing a layout with dataSet and that dataSet exists in our target CMS (with different dataSetColumnId's).

The logic is that we match the dataSet, we match the columns and then we go through each datasetview and ticker widgets in the source layout to find and replace dataSetColumnId's.

Unfortunately that's not working as expected at the moment.

Current logic is assuming that we have priorDataSetColumnId containing the dataSetColumnId's from the source, the issue seems to be that this parameter is empty - as such when we try to find columns Ids there to replace them we are not able to do that, hence nothing gets replaced.

priorDataSetColumnId is populated when we clone a dataSet, however we are not cloning dataSet when we've a matching dataSet in the target CMS, in fact we can't do that.

Source dataSetColumnId's are stored in the dataSet->dataSetColumnId we can use that or assign those values to the column->priorDataSetColumnId and then replace those with the column->dataSetColumnId in places where it matches other existing conditions.

We will need to investigate the best way to make it work in all cases.

@PeterMis PeterMis added the bug label Apr 27, 2018
@PeterMis PeterMis added this to the 1.8.10 milestone Apr 27, 2018
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant