{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":17236735,"defaultBranch":"develop","name":"rippled","ownerLogin":"ximinez","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2014-02-27T04:33:56.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6757714?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1721856557.0","currentOid":""},"activityList":{"items":[{"before":"45ac3b1dc512b881b85e4c811e563ef9d4fc761d","after":"71f0841aa0249594ee82886bac26252ac967b811","ref":"refs/heads/sc-github-ci","pushedAt":"2024-07-25T21:58:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"run pipelines on self hosted runner","shortMessageHtmlLink":"run pipelines on self hosted runner"}},{"before":"094f2ef24599cddcaef6b08c5a77c71be873fc2f","after":"95b44db82c9fba5324525e161488a1084d407132","ref":"refs/heads/sc-github-ci2","pushedAt":"2024-07-25T21:58:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Fix race conditions in shard:\n\nThreadSafetyAnalysis was used to identify race conditions in this file.\nThis analysis was modivated by a (rare) crash while running unit tests.\n\nAdd locks to Shard flagged by ThreadSafetyAnalysis","shortMessageHtmlLink":"Fix race conditions in shard:"}},{"before":"244c05e415f065acc05b80436c7082ed4fd21049","after":"f42d54445b022182bddda39041d071f98ae524c5","ref":"refs/heads/invariant-acctdelete-wip","pushedAt":"2024-07-25T21:58:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[FOLD] Double-check that Invariants_test can't be unity","shortMessageHtmlLink":"[FOLD] Double-check that Invariants_test can't be unity"}},{"before":"b679db33afec871b581fc9c6b67bd20ca5408639","after":"aed8f13ac8d4e54c77277fc8a44cda6b72c9b41e","ref":"refs/heads/env-failures-wip","pushedAt":"2024-07-25T21:58:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[WIP] Checkpoint - diagnostic test log messages","shortMessageHtmlLink":"[WIP] Checkpoint - diagnostic test log messages"}},{"before":"7f8fd30156df2c26281df1717d11f836d65431fa","after":"69ae64b8f0adb3a3f79560c3c806ffe320217554","ref":"refs/heads/downstream","pushedAt":"2024-07-25T21:58:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Add missing headers, and simplify STTx::checkSign interface\n\n* For downstream projects that depend on xrpl library","shortMessageHtmlLink":"Add missing headers, and simplify STTx::checkSign interface"}},{"before":"b5767d0ced0c0d73c7f08a6f77fa119d8a528749","after":"cd62abff9b5c6c38e38b9f81a327238585694b87","ref":"refs/heads/flow_assert","pushedAt":"2024-07-25T21:58:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Disable problematic asserts","shortMessageHtmlLink":"Disable problematic asserts"}},{"before":"9c07449d23500ade67f858659b39b46c5efbc7eb","after":"3aca20bc6e588a3c5f697003833c44382f7bc392","ref":"refs/heads/x-startup-manifest-warnings","pushedAt":"2024-07-25T21:58:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Lower the log level of some manifest warnings on startup","shortMessageHtmlLink":"Lower the log level of some manifest warnings on startup"}},{"before":"e3b911b29799d4d994ba2e412142be4975935196","after":"ba58e645b05360df16d48d05a71ddebb814a38a7","ref":"refs/heads/apply-steps-UnknownTxn","pushedAt":"2024-07-25T21:57:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Refactor to use an `UnknownTxn` class instead of exceptions\n\n* Follow-up to #4710","shortMessageHtmlLink":"Refactor to use an <code>UnknownTxn</code> class instead of exceptions"}},{"before":"e9eb189c230487083d68fc0d7e841e997b58a515","after":"352471cf07081e7fb79cf50a7a955aed3c2334ae","ref":"refs/heads/validatortrie","pushedAt":"2024-07-25T21:57:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Add string to log messages","shortMessageHtmlLink":"Add string to log messages"}},{"before":"93ae567b18723c111ddea547f03268c0cde43b12","after":"cdadf0eea153d86ee96068b2ca5d481ce163128b","ref":"refs/heads/logging","pushedAt":"2024-07-25T21:57:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[WIP] Find everywhere Json is written to the log\n\n* Get rid of operator<<(std::ostream&, const Value& root), and\n  fix everything that breaks.","shortMessageHtmlLink":"[WIP] Find everywhere Json is written to the log"}},{"before":"7a3b14cfc1440ca1f0c081f09e585eb501b6df26","after":"657c708fad80c7c991fa38147882eacd5b0cdc6b","ref":"refs/heads/thread_fix","pushedAt":"2024-07-25T21:57:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Fix thread utilities for Windows","shortMessageHtmlLink":"Fix thread utilities for Windows"}},{"before":"022ff43703a55c41fbd344494eb3f7d52c660ae2","after":"1984e0583896cc04ae6fd94249b583de87754cc7","ref":"refs/heads/txq-duration","pushedAt":"2024-07-25T21:57:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[FOLD] Make the unhealthy factor a constexpr param, set to 3","shortMessageHtmlLink":"[FOLD] Make the unhealthy factor a constexpr param, set to 3"}},{"before":"a6473fd1b796d70da5dca094e0386b477dc1d916","after":"f1e5433f07bc1b5e4802025e51457468fb0fc4f7","ref":"refs/heads/txqlock","pushedAt":"2024-07-25T21:57:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Update TxQ lock safety","shortMessageHtmlLink":"Update TxQ lock safety"}},{"before":"12db4aeed47f159e3addc7b79e0c4464b281e966","after":"9c27b1371c2ae378db7b01b03146e5fae86a8458","ref":"refs/heads/unlwarning","pushedAt":"2024-07-25T21:57:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Log different messages for malformed and untrusted UNL manifests","shortMessageHtmlLink":"Log different messages for malformed and untrusted UNL manifests"}},{"before":"5a2f1fa5f471226db3b2d454e7c408267085d2a7","after":"e8cfa1badcfd761339c122134633acb2c3be7947","ref":"refs/heads/txq-order-lcl-sorttests","pushedAt":"2024-07-25T21:57:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[FOLD] Fix include paths","shortMessageHtmlLink":"[FOLD] Fix include paths"}},{"before":"46c2873138b3452d0602d266a90592d75e717bdd","after":"ae3eea0b031f5c5889d4d99b26108bc8e08af53e","ref":"refs/heads/unlsync","pushedAt":"2024-07-25T21:57:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[WIP] Toying with the idea of VL exchange\n\n* Log Validator Lists received from peers","shortMessageHtmlLink":"[WIP] Toying with the idea of VL exchange"}},{"before":"1eb92c997af1518134a94c9859c061906656e7b9","after":"bb06b7e2ab84eda69be39ab3bc7f22677e783257","ref":"refs/heads/logging2","pushedAt":"2024-07-25T21:56:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Log Validator Lists received from peers","shortMessageHtmlLink":"Log Validator Lists received from peers"}},{"before":"2d537e10353a7e68c340b455348288972c653dbe","after":"fa7dcebd969c1ee5b56b8b0f29bc357b20b53140","ref":"refs/heads/x-subscribe-book","pushedAt":"2024-07-25T21:56:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[fold] logging","shortMessageHtmlLink":"[fold] logging"}},{"before":"95f03a9535254b88d153504f21fe992d1fe742ff","after":"96716998c13fab9f89b41e355e737c923d5b81b3","ref":"refs/heads/action-wip","pushedAt":"2024-07-25T21:56:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Switch back to the Github hosted runners","shortMessageHtmlLink":"Switch back to the Github hosted runners"}},{"before":"2fb5a5c5d914fe1f920a8b60c0f1f075a2577879","after":"78e4c1ee0ae9f6e01a39e767fd59b9fd66d4e397","ref":"refs/heads/github-ci","pushedAt":"2024-07-25T21:56:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Squashed commit of the following:\n\ncommit 647d97921476e37dfc536dd4b2d250eb80eaff3b\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Wed Jun 1 17:57:22 2022 -0400\n\n    [FOLD] Restore the \"cancel previous runs\" action\n\ncommit 69130e9b4324e9d8361c4a1e4f0373d534b51c9d\nAuthor: Shi Cheng <cshi@ripple.com>\nDate:   Thu May 26 17:51:20 2022 +0800\n\n    enable build for gcc8/clang8/macOS\n\ncommit 4d494f062c4af6635e5c0fbd632bdacd6801bbb1\nAuthor: Shi Cheng <cshi@ripple.com>\nDate:   Thu May 5 15:11:34 2022 +0800\n\n    change to manual trigger for macos pipeline\n\ncommit 78ae64295b9be435ad36e5246e1c05e2077b3562\nAuthor: Shi Cheng <cshi@ripple.com>\nDate:   Thu May 5 14:42:14 2022 +0800\n\n    run pipelines on self hosted runner\n\ncommit b414cd9e755129325f2211b21a2e8b44a2994c04\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Wed Jun 1 18:59:34 2022 -0400\n\n    [FOLD] Make NINJA_BUILD flag explicit on derived builds\n\ncommit eba651189c388c8dd97f93b2e6ec420ec0c8276f\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Wed Jun 1 17:38:47 2022 -0400\n\n    [FOLD] Consolidate the special case linux jobs\n\ncommit f72b4e6eff7c3bbdac2a64f2fb081adc63f944c8\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Wed Jun 1 15:19:00 2022 -0400\n\n    [FOLD] Linux runner fixes:\n\n    * Consolidate manual test runners\n    * Continue gracefully if no cache in derived jobs\n    * Retry unit tests up to 2 more times automatically\n\ncommit f3f922a130cd15ffdab2e6dffde2c70f76632ae2\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Tue May 31 20:19:30 2022 -0400\n\n    [FOLD] Try to pull all the linux jobs into one workflow\n\n    * Because self-hosted runners are more reliable, AND github actions now\n      supports re-running only failed jobs\n\ncommit 17a6eb12daf6f255a3689089e16e974181bd5130\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Tue May 31 19:32:52 2022 -0400\n\n    [FOLD] Fix Roles test under IPv6\n\ncommit 47538aeb122428d771ee28a8ae781baf59518935\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Fri May 27 21:04:42 2022 -0400\n\n    [FOLD] Try to fix MacOS builds by ignoring warnings\n\ncommit b045a766ada3920c9303b1ca458ddcb08b2a9b36\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Thu May 26 15:29:00 2022 -0400\n\n    [FOLD] Update \"min cmake\" test to use 3.16, which is now the min\n\ncommit 3e4a7474b948ed399670711123dcd8f8e07eb985\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Thu May 26 15:13:51 2022 -0400\n\n    [FOLD] Use updated executable name for reporting mode\n\ncommit 1f08975eaaf4da3104ff969dcd04006c08fae24f\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Tue May 24 19:21:03 2022 -0400\n\n    [FOLD] Fix unit test to use updated TER code\n\ncommit 7176bdd30f002e4d973257f9c255207a087f3ea7\nAuthor: Ed Hennis <ed@ripple.com>\nDate:   Tue May 24 16:19:32 2022 -0400\n\n    Revert \"Add a test case demonstrating VS2019 constexpr char* problem:\"\n\n    This reverts commit 1a328abef4ebf1b8c68425571449716d3784030b.\n\ncommit e19e33a258f5d5e8789b454f99ae2e3cbb43fa8d\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Fri Oct 1 18:46:33 2021 -0400\n\n    Revert \"Add missing \"deque\" headers in a bunch of places\"\n\n    This reverts commit 46bbac25bf8d8c93b465e241b3cb8ec9e13179de.\n\ncommit 80694f6e3de475ebbaadec3097522474256b0375\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Thu Sep 30 11:23:07 2021 -0400\n\n    fixup! [FOLD] Restructure MacOS caches\n\ncommit bc81cd92efabaff5cf4fe9493beb818ef9b4e459\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Tue Sep 28 15:32:52 2021 -0400\n\n    [FOLD] Restructure MacOS caches\n\ncommit 93337bf24fb418e1bea6dbfee2413dc7c37a3437\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Tue Sep 28 13:28:48 2021 -0400\n\n    [FOLD] Update GH CI documentation\n\ncommit 95245bbf74ff25c200b07e7f04fdde281bc70f8a\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Fri Sep 10 12:06:59 2021 -0400\n\n    [FOLD] Make the check tests manual on Github CI Windows\n\n    * Don't restrict Windows test threads\n\ncommit 1dbe29680e918cdcd30140728a885e736e2b21ac\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Wed Sep 1 15:09:02 2021 -0400\n\n    [FOLD] Restructure the linux caches\n\n    * Reuse the NIH src cache across configs\n    * Store timestamp (*_stamp) and SQLite download folders in src cache\n    * Break up docker image names to fix artifact naming\n\ncommit 9a4c23d97037cb2b833769526e53489a6cb8c260\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Wed Sep 1 13:06:29 2021 -0400\n\n    [FOLD] Review feedback: Clarified a few points in the README\n\ncommit fd86f7a6f7430f3f4a34972115c069e89f20cf89\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Thu Jun 24 14:09:36 2021 -0400\n\n    [FOLD] Github folder documentation\n\ncommit 01733637dfd822d840c004a09569697de3ecccd9\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon Jul 12 19:38:33 2021 -0400\n\n    [FOLD] Move the build-action folder up a level\n\ncommit 8850a4e68f7dedab1fcb3f3d21b4d90c94dfef18\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Thu Jun 17 17:48:35 2021 -0400\n\n    [FOLD] Improve Linux and Mac job naming\n\ncommit 76430401c8f1122c7e5f3e130ceac11eb8dc03c4\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon Jun 14 20:33:37 2021 -0400\n\n    [FOLD] Pull files out of unity to reduce CI OOM issues\n\n    * Also include a debugging step for failed unity builds\n\ncommit 59157827100bd61c1db608a4dc4ff5a5008561c7\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon Jun 14 20:35:02 2021 -0400\n\n    Revert \"[FOLD] Reduce the unity file size for gcc-9 release builds\"\n\n    This reverts commit 7f8af40482f996edd95f345545eadbc4261595bf.\n\ncommit 5421b2f71370a0dbe78039e87bfe25e156485702\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon Jun 14 17:54:47 2021 -0400\n\n    [FOLD] Run MacOS unit tests single thread\n\ncommit 5be6d447af930867dc194172ed16d627c1a07ed5\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon Jun 14 16:52:34 2021 -0400\n\n    [FOLD] Remove inputs and outputs from build-action\n\n    * All parameters must be passed in the env, like build-and-test.sh\n\ncommit 04413067fa26a2060429a2fd85bc4e891e4b12bc\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon Jun 14 13:35:37 2021 -0400\n\n    [FOLD] (Tweak) Rename MacOS test runner job\n\ncommit 31befacd01444ac3ae15af5b2401d01c969a41f6\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon Jun 14 13:30:14 2021 -0400\n\n    [FOLD] Reduce the unity file size for gcc-9 release builds\n\ncommit e9c5dd6894e131cd3ee3b07c3105c1d2d8d9ab14\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Tue Jun 8 17:33:18 2021 -0400\n\n    [FOLD] Review feedback: Cleanups:\n\n    * Restructure job matrices to use env when there's one option\n    * Remove image param from build-action\n    * Limit Visual Studio test jobs to help make them more reliable\n\ncommit 4ed952a73c13f13336cc54e4ff5fe557c825a96f\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Tue Jun 8 17:31:58 2021 -0400\n\n    [FOLD] Change some \"== false\" comparisons to \"!= true\"\n\ncommit 98ed06942a6aa9393a428fe16c9d5fb239ee33a2\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Tue Jun 8 17:04:38 2021 -0400\n\n    [FOLD] Review feedback: change \"post condition\" to a \"warning\"\n\ncommit df47bc0b572bbc7aa366065b0809174bc837e8ba\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Fri Jun 4 16:17:07 2021 -0400\n\n    [FOLD] Reenable the manual DatabaseShard test, fixed in 1.8.0-b3\n\ncommit 548e4f98ec7ef89a0701726e62cfbd94c2b79195\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Fri May 28 18:17:29 2021 -0400\n\n    [FOLD] review feedback (action):\n\n    * Clean up cache space regardless of size\n    * Improve clarity of some comments\n    * Remove matrix.CMAKE_ADD where it's not used\n\ncommit 304fae6303516fb4a36dcf7e7fe1c5052bedadfd\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Fri May 28 14:31:13 2021 -0400\n\n    [FOLD] review feedback:\n\n    * clean up cmake formatting\n    * Remove redundant `install:` section in Travis config\n    * Update cancel workflow action version and add a note about when it\n      works\n\ncommit e12540b3f4077b522ace883d62c4feaa9f6d740b\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Fri May 28 12:16:00 2021 -0400\n\n    [FOLD] NOW what's going on with Windows builds:\n\n    * Dump vc environment if parsing fails\n\ncommit b7b9826f108c03fc05539f97a701a36041dca42d\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Fri Nov 6 13:53:42 2020 -0500\n\n    Build and test rippled in Github Actions:\n\n    * VS19 debug builds DO NOT RUN TESTS. Known issue with those builds, but\n      if it gets fixed, I want to be able to see those tests succeed.\n\ncommit 3836bcd7f926a7851f570f7f2f82c79c3ffe61fd\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon May 17 17:51:22 2021 -0400\n\n    Add a test case demonstrating VS2019 constexpr char* problem:\n\n    * This intended to future-proof in two ways. 1) so we don't lose the\n      institutional knowledge why we keep using VS2017. 2) if/when the issue\n      is resolved, we'll know it.\n\ncommit bcafe63e8eb5966045b221547ae4df0913046d06\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon May 17 17:47:23 2021 -0400\n\n    Env unit test RPC errors return a unique result:\n\n    * telLOCAL_ERROR is not new, but it is not used anywhere in the\n      transaction engine, unlike temINVALID. This will make those types of\n      errors distinct and easier to diagnose.\n\ncommit fa29bee69af601f20923bcd74257cc4b785b18b2\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon May 17 17:45:42 2021 -0400\n\n    Add missing \"deque\" headers in a bunch of places\n\ncommit 3b9a6d91af1541557f716581cff79d77248b8ecf\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon May 17 17:37:50 2021 -0400\n\n    Get the list of manual tests from rippled:\n\n    * Split that function into a separate file so it can be used in\n      other contexts.\n\ncommit 533e45927ba230205e600986a50a8e4ec90e61ab\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon May 17 17:34:54 2021 -0400\n\n    Improve Windows Visual Studio CMake build compatibility\n\ncommit 5377eaafa30383eb19a72eba6bd884aaf9132364\nAuthor: Edward Hennis <ed@ripple.com>\nDate:   Mon May 10 13:27:12 2021 -0400\n\n    Update version of vcpkg for Windows builds:\n\n    * Include a warning message when a newer version is found","shortMessageHtmlLink":"Squashed commit of the following:"}},{"before":"04d64a3ea693159a47bbff23b225b5fbc04b2c21","after":"c5b8e01ea68961654043dfa836d31e810fd09245","ref":"refs/heads/overflow2","pushedAt":"2024-07-25T21:56:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Prevent divide by zero in mulDiv:\n\n* Every call to mulDiv either uses a literal or constexpr, checks for 0,\n  or throws on overflow.","shortMessageHtmlLink":"Prevent divide by zero in mulDiv:"}},{"before":"66b09935bbadc13b54a4a7eba3b147cc5a17b165","after":"f2b86d476d15d825e4bb7519bef2b626f182a519","ref":"refs/heads/hooks-merge","pushedAt":"2024-07-25T21:56:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/develop' into hooks-merge\n\n* upstream/develop:\n  chore: Add comments to SignerEntries.h (5059)\n  chore: Rename two files from Directory* to Dir*: (5058)","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/develop' into hooks-merge"}},{"before":"7634463b14f6ff2654f063f0a02b03877e6fce1f","after":"7fac4b238be0a8cfc1b66e8c68a856f2768b2465","ref":"refs/heads/pr/nudb-header","pushedAt":"2024-07-25T21:55:50.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/develop' into pr/nudb-header\n\n* upstream/develop:\n  chore: Add comments to SignerEntries.h (5059)\n  chore: Rename two files from Directory* to Dir*: (5058)","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/develop' into pr/nudb-header"}},{"before":"c242c7169198c7ee3c6c72fcf5908c933a02c967","after":"60bba1f12ca4c21e9132382fdfa40a82a9350b26","ref":"refs/heads/pr/merging","pushedAt":"2024-07-25T21:54:51.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/develop' into pr/merging\n\n* upstream/develop:\n  chore: Add comments to SignerEntries.h (5059)\n  chore: Rename two files from Directory* to Dir*: (5058)","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/develop' into pr/merging"}},{"before":"d51702d2acae3859e0cc4d3e96ddde3bffabbeb2","after":"0c867c9217e233b5b1d12bad14e977d7f87a7604","ref":"refs/heads/pr/test_fixes","pushedAt":"2024-07-25T21:51:04.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/develop' into pr/test_fixes\n\n* upstream/develop:\n  chore: Add comments to SignerEntries.h (5059)\n  chore: Rename two files from Directory* to Dir*: (5058)","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/develop' into pr/test_fixes"}},{"before":"c7e08bc8ba0e32cbc3488296d2bc4fde19851073","after":"3054f5a4421540aa0c579e8cb82fe6330f17193a","ref":"refs/heads/relay","pushedAt":"2024-07-25T21:50:53.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/develop' into relay\n\n* upstream/develop:\n  chore: Add comments to SignerEntries.h (5059)\n  chore: Rename two files from Directory* to Dir*: (5058)","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/develop' into relay"}},{"before":"bdbea310f70ba9ede65dc970aeb744cd48f54ac3","after":"a6043f1a683aeea51fea38d105943b930c4e46b2","ref":"refs/heads/shamapstore-backoff","pushedAt":"2024-07-25T21:50:42.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/develop' into shamapstore-backoff\n\n* upstream/develop:\n  chore: Add comments to SignerEntries.h (5059)\n  chore: Rename two files from Directory* to Dir*: (5058)","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/develop' into shamapstore-backoff"}},{"before":"ad14d09a2b6de8d8847124476485682433f2e235","after":"21a0a64648949372841f5edde8eef7771d7b7d9f","ref":"refs/heads/develop","pushedAt":"2024-07-25T21:50:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"chore: Add comments to SignerEntries.h (#5059)","shortMessageHtmlLink":"chore: Add comments to SignerEntries.h (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2399451024\" data-permission-text=\"Title is private\" data-url=\"https://github.com/XRPLF/rippled/issues/5059\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/XRPLF/rippled/pull/5059/hovercard\" href=\"https://github.com/XRPLF/rippled/pull/5059\">XRPLF#5059</a>)"}},{"before":"e52ae9e86117f2cf62c8eb70b5c163e9285e5376","after":"c242c7169198c7ee3c6c72fcf5908c933a02c967","ref":"refs/heads/pr/merging","pushedAt":"2024-07-25T21:49:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Review feedback from @Bronek","shortMessageHtmlLink":"Review feedback from <a class=\"user-mention notranslate\" data-hovercard-type=\"user\" data-hovercard-url=\"/users/Bronek/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/Bronek\">@Bronek</a>"}},{"before":"045e50fbd8e1d8a73cece4c8d4da4fe1fb073576","after":"d51702d2acae3859e0cc4d3e96ddde3bffabbeb2","ref":"refs/heads/pr/test_fixes","pushedAt":"2024-07-25T20:42:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"[FOLD] Review feedback from @ckeshava:\n\n* Add the same null check in the `flags` class as `nflags`.","shortMessageHtmlLink":"[FOLD] Review feedback from <a class=\"user-mention notranslate\" data-hovercard-type=\"user\" data-hovercard-url=\"/users/ckeshava/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/ckeshava\">@ckeshava</a>:"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEiXifmQA","startCursor":null,"endCursor":null}},"title":"Activity · ximinez/rippled"}