Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Standardize runner scripts #1
Conversation
didrocks
added some commits
Nov 17, 2015
|
Looks very good, thank you for the oatch and the debugging work! :-) |
added a commit
that referenced
this pull request
Nov 17, 2015
ximion
merged commit 5bb308d
into
ximion:master
Nov 17, 2015
didrocks
deleted the
didrocks:setuptools_scripts
branch
Nov 17, 2015
pushed a commit
to iainlane/appstream-dep11
that referenced
this pull request
Feb 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
didrocks commentedNov 17, 2015
When running
dep11-generatorscript in our infra from git in a virtualenv, we would get some stacktrace (see below).The issue is that
__spec__(new in python 3.4) needs to be define when using a pool of process with the multiprocessing module, if initialized with set_start_method('forkserver').When using the setuptools generated script (in the script section), those are using
__import__()to load the executable scripts, which doesn't set those properties. The bug seems thus to be in that tool.However, a more correct/modern way is to use the module
entrypoints()for setup.py. This one generate in a similar way the executable script, but does something way more standard like what we have inimport <module_name>:__import__to load modulesI thus added this refactoring and moving the code to the dep11 module themselves
main()method. I did rewrite the scripts themselves that I guess you are using for testing, but they are not installed/shipped anymore by setuptools. That way, we use a similar way to load and start our local scripts for testing than the one installed on the system.The stacktrace was: