Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.5 generates truncated metadata for some packages #47

Closed
antonio-rojas opened this issue Jul 11, 2017 · 6 comments
Closed

0.6.5 generates truncated metadata for some packages #47

antonio-rojas opened this issue Jul 11, 2017 · 6 comments

Comments

@antonio-rojas
Copy link
Contributor

With 0.6.5 metadata is incorrectly extracted for some packages, giving a broken xml that is not validated by appstream

@antonio-rojas
Copy link
Contributor Author

Metadata for kdenlive as extracted by asgen 0.6.5. Note the many missing Name fields

asgen-0.6.5.txt

@antonio-rojas
Copy link
Contributor Author

Metadata for kdenlive as extracted by asgen 0.6.3

asgen-0.6.3.txt

@antonio-rojas
Copy link
Contributor Author

kdenlive metainfo provided by upstream

kdenlive.txt

@antonio-rojas antonio-rojas changed the title 0.6.5 generated truncated metadata for some packages 0.6.5 generates truncated metadata for some packages Jul 11, 2017
@antonio-rojas
Copy link
Contributor Author

Turns out the asgen version is irrelevant, this regressed in appstream 0.11.1. Downgrading to 0.11.0 fixes the metadata extraction

@ximion
Copy link
Owner

ximion commented Jul 11, 2017

Jup, this has to be an AppStream bug.
I will look into it when home.

@ximion
Copy link
Owner

ximion commented Jul 11, 2017

Thanks for reporting this! It was a rather simple mistake done while refactoring the XML code (return -> continue).
Anyway, this has a test now so it won't appear again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants