Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export data using the same directory hierarchy as the repo #5

Closed
neilmayhew opened this issue Apr 28, 2016 · 3 comments
Closed

Export data using the same directory hierarchy as the repo #5

neilmayhew opened this issue Apr 28, 2016 · 3 comments

Comments

@neilmayhew
Copy link
Contributor

The repo expects data to be in a dep11 subdirectory but asgen puts it directly under the directory for the distribution. This stops me from rsyncing the data directly into the dists directory of the repo.

The following change fixes this:

diff --git a/source/engine.d b/source/engine.d
index ff3837c..f9a960f 100644
--- a/source/engine.d
+++ b/source/engine.d
@@ -216,7 +216,7 @@ public:
         mdataEntries ~= getMetadataHead (suite, section);

         // prepare destination
-        auto dataExportDir = buildPath (exportDir, "data", suite.name, section);
+        auto dataExportDir = buildPath (exportDir, "data", suite.name, section, "dep11");
         auto hintsExportDir = buildPath (exportDir, "hints", suite.name, section);

         mkdirRecurse (dataExportDir);
@ximion
Copy link
Owner

ximion commented Apr 28, 2016

Hmm, not sure if that's useful to do (you can do per-suite syncing even with the old scheme), especially because it adds another, weird directory for people generating XML.
I can't make this default because it would break both Debian and Ubuntu atm, which expect the existing layout...

I could add a feature flag for this, but given that you could also solve this easily with symlinks, I am not sure if it's worth it.

@neilmayhew
Copy link
Contributor Author

I see your point about per-suite syncing. I guess I can get by without this change.

@ximion
Copy link
Owner

ximion commented Apr 28, 2016

You could also quite easily get this structure by creating a new directory and link the data/suite/section directory as "dep11" wherever you want, then call rsync with its follow-symlinks option.
That would give you the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants