Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning on https->http redirect of screenshot downloads? #58

Closed
hsitter opened this issue Jan 9, 2018 · 1 comment
Closed

warning on https->http redirect of screenshot downloads? #58

hsitter opened this issue Jan 9, 2018 · 1 comment
Labels

Comments

@hsitter
Copy link
Contributor

hsitter commented Jan 9, 2018

Screenshots that had https as url currently can get redirected to http without any warnings being raised as it seems curl's get! simply follows https->http.

As this degrades authenticity of the data it would be prudent to at least raise a warning about this and have authors either use http on the url to begin with or ensure the redirect chain does not drop to http. A MITM attack could inject unwanted art into the final data set, making both the distributor and the software look bad.

@ximion
Copy link
Owner

ximion commented Jan 9, 2018

I don't think this is a super-realistic scenario (MITM attacks on the generator servers), but nevertheless this is a bug that should be closed.
I wasn't aware that Curl does this. We'll need to figure out how to address this, or check if nicer API handles this scenario better.

@ximion ximion added the bug label Jan 9, 2018
ximion added a commit that referenced this issue Nov 3, 2018
Instead of just throwing a warning, we will just disallow this behavior
in general, as it usually indicates some kind of bug or usage error.
I also could not find any website that actually does this in the wild.
This resolves issue #58
@ximion ximion closed this as completed Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants