Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting the code with dfmt #76

Closed
Cogitri opened this issue Apr 29, 2020 · 2 comments
Closed

Formatting the code with dfmt #76

Cogitri opened this issue Apr 29, 2020 · 2 comments

Comments

@Cogitri
Copy link
Contributor

Cogitri commented Apr 29, 2020

It'd be nice if appstream-generator was formatted with dfmt to allow for a consistent style across all files.

@ximion
Copy link
Owner

ximion commented Apr 29, 2020

I'll just say no to that for now, at least unless Dfmt can be tweaked to follow the coding style of asgen at the moment, which is basically AppStream's coding style (space before brackets, brackets in-line with condition statements, ...) but with 4-spaces instead of tabs for indentation. And I really don't want to change that, the churn would be massive and also pretty pointless (and make future bisecting hard).
If Dfmt grew flags to configure it to replicate the current style as much as possible, I would be very open to having it though.

@ximion ximion closed this as completed Apr 29, 2020
@Cogitri
Copy link
Contributor Author

Cogitri commented Apr 29, 2020

dfmt does have some flags, I'll see if I can get it to look like the current source of a-g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants