Metainfo files are ignored for Elementary OS apps

[City-busz]

I usually get 'no-metainfo' warnings for Elementary OS applications. The metainfo file is ignored by appstream-generator, and just the desktop file is processed. Tested apps (on Arch Linux) with their metainfo files:

• bookworm
• ciano
• minder
• notes-up
• pdftricks
• spice-up
• torrential
• vocal

It seems that when I specify the corresponding desktop file explicitly in the metainfo file with the <launchable type="desktop-id"> tag, it solves the problem.

Elementary OS applications usually use the same name for desktop and metainfo files , e.g.:

• desktop file: /usr/share/applications/com.github.davidmhewitt.torrential.desktop
• metainfo file: /usr/share/metainfo/com.github.davidmhewitt.torrential.appdata.xml

So could appstream-generator handle these applications better, or is the <launchable> tag necessarily for the pairing?

[ximion]

The <launchable> tag is mandatory, but we did have some workaround in place to just check "ID + .desktop" as heuristic for finding desktop-entry files. That probably broke in the move to more ascompose components, I'll have a look if it's feasible to add this feature back.
Adding launchable tags is a good idea in any case though :-)

[City-busz]

I found the problem! cid ~ ".desktop" is not removed from desktop list, so it processed twice, and the latter overwrites the previous data loaded from metainfo. See #91 for a simple fix.