Support DDTP translations #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 17, 2016 09:45
You have to convert them all when using `format', but passing "%s" as a parameter works around that. We need one because `downloadIfNecessary' uses it to add the extension.
| if (match.empty) | ||
| continue; | ||
|
|
||
| if (!ret.data.canFind (match[1])) |
There was a problem hiding this comment.
There's no builtin set type, but that's what I really want here.
There was a problem hiding this comment.
Jup, I know and it's annoying - but you can use an associative array instead of a set.
See https://github.com/ximion/appstream-generator/blob/master/source/engine.d#L567 for an example.
(actually, we could make our own set type with this)
| * | ||
| * Returns: The data if successful. | ||
| */ | ||
| string[] getFile (const string path, const uint retryCount = 5) |
There was a problem hiding this comment.
This should probably rather be getFileContent because getFile makes me think I get a File or a filename back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Here's what we do here (requires libas master and my PR ximion/appstream#64 or an equivalent fix):
File). One for returning astring[], and the other for downloading to a given location on the filesystem.InReleaseand find all translations referenced in there (TODO: verify hashes - use libapt or something).DebPackage.Component. For this we need to turn off libas's fallback which always returns theCtranslations when a language isn't translated - that's the bit that requires libas master.Style tips and other feedback appreciated.