Download file to memory fix #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 1, 2016 11:56
The documentation says The locations pointed to by ptr and sizeloc are used to report, respectively, the current location and the size of the buffer. The locations referred to by these pointers are updated each time the stream is flushed (fflush(3)) and when the stream is closed (fclose(3)). so we need to close it before reading from the pointer. To do this we move the memstream handling into the `if` block where it is needed.
iainlane
force-pushed
the
download-file-to-memory-fix
branch
from
2ba0d12
to
575f7ea
Compare
|
I guess you figured it out, but the answer is that you have to |
|
Yes, but you could just drop the scope(exit) and simply close the thing explicitly ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was using
make fast, and noticed thatgetFileContentswasn't working. I suspect that at higher optimisation levels thescope (exit) fclose (f)is happening earlier. It needs to happen before we read from the pointer (see the full commit message).(Also squash some overly verbose debug logging, which isn't really related to this bug, but here we are.)