engine: Don't clean packages in base suites #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're configured to process a suite without its base, we will currently clean the base suite's packages every time 'clean' is run. That means that the subsequent 'process' runs will reprocess the same pacakges. Fix this by keeping the packages in base suites too.
|
Hmm, it's still scanning too much every time - must not be saving results somehow. This fix is needed to avoid too much cleaning, but probably another will be required too... |
|
I didn't test it, but it looks sane - thanks for the patch! Can you give examples of duplicate processing, because that really shouldn't happen - unless we clean too many things, run the cleanup action with |
|
I'll file an issue to discuss that bit - thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I'm trying a configuration with
xenial-updates(etc) but notxenialand was like "why is it processing all of xenial every time?"Turns out that, because I run clean each time, it was cleaning all of
xenial:(. I think that clean should keep base suites around too.