hints: icon-not-found: Explain the symlink problem for Debian & Ubuntu #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should maybe conditionalize the hint, so it only gets shown on Ubuntu... But this is fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was just diffing the
Componentsbetween as-dep11 and asgen, and there are actually quite a few of these. I think we should at least explain the problem in the output.If it's possible to only output this on Debian & Ubuntu then we should do that, but I don't think it is so it's okay to have it for everyone IMO.
Feel free to edit the message.