download: If we have a last-modified date, set the mtime of the target file #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t file This only works for HTTP, not FTP. Should hopefully fix asgen considering suites as changed each time, which I think happened because the Packages file got the current mtime, so it was always considered to be newer. Fixes ximion#35
ximion
reviewed
Nov 17, 2016
| @@ -370,6 +374,10 @@ body | |||
| downloader.dataTimeout = dur!"seconds" (30); | |||
| downloader.onReceive = (data) => onReceiveCb (dest, data); | |||
| downloader.perform(); | |||
| if ("last-modified" in downloader.responseHeaders) { | |||
There was a problem hiding this comment.
If you want, you can optimize this slightly like this:
immutable lastModifiedP = "last-modified" in downloader.responseHeaders;
if (lastModifiedP !is null) {
auto lastmodified = *lastModifiedP;
ret = parseRFC822DateTime(lastmodified);
}=> one lookup instead of two.
There was a problem hiding this comment.
I hope that hashing is super fast (and maybe this could be optimised anyway), so this shouldn't really matter...
There was a problem hiding this comment.
It is very fast and I assume the hash table is also pretty small, so this is indeed a micro optimization. Not sure what the compiler does here and how smart it is in optimizing - would be pretty cool if it did optimize that bit :-)
Anyway, this comment was from the "pedantic" and maybe-do-it class of comments ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
You know what this is about. :)