Add basic HiDPI support #48
Conversation
|
Note that this doesn't cover all the cases but is a preliminary work on HiDPI |
src/asgen/utils.d
Outdated
| } | ||
|
|
||
| int opCmp (const ImageSize s) const | ||
| { | ||
| if (this.scale != s.scale) { | ||
| if (this.scale > s.scale) | ||
| return 1; |
There was a problem hiding this comment.
This doesn't look right... That was an 32x32@2 size will be ordered before an 128x128 size. I don't think this has practical implications, but we should likely resolve that so nobody wonders about this in future.
|
Looks pretty good - the tarball generation is missing, but that's trivial to do. Did you test this and see if icons are correctly generated? |
|
Should be fixed, I'll try to generate the files on the elementary PPA once I get some time |
| @@ -129,6 +136,9 @@ public: | |||
|
|
|||
| private bool directoryMatchesSize (Algebraic!(int, string)[string] themedir, ImageSize size) | |||
| { | |||
| int scale = themedir["scale"].get!(int); | |||
There was a problem hiding this comment.
You could make this just themedir["scale"].get!int;, D doesn't need the brackets here (that particular code is rather old from when I didn't know that much about D yet ^^)
But that's just a style-thing, no need to change it.
| @@ -320,10 +320,13 @@ public: | |||
|
|
|||
| // prepare icon-tarball array | |||
| immutable iconTarSizes = ["64", "128"]; | |||
| immutable iconTarScales = ["1", "2"]; | |||
There was a problem hiding this comment.
I wonder whether we should iterate over wantedIconSizes here, instead of defining another array (minor thing though).
|
Still looking good, in fact I think this is merge-ready. I'd just like to know whether you tested this meanwhile (some additional data on this is helpful). |
|
Hmm, it looks like I forgot to merge this... Sorry for the delay! I'll merge it and resolve a few minor quirks later. |
No description provided.