New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: allow overriding export dir via --exportDir #82
Conversation
This is useful for e.g. exporting to a versioned (by date) dir.
50ba3b3
to
881ca84
Compare
|
Thanks! |
|
I made a few changes to this commit, to ensure the paths are always sane. Also, keep in mind that state is stored in the export directories, so you should never move the export path once the generator has run once with these settings, unless data is reprocessed ( |
|
Oh, thanks for the heads up :) We don't move the exported dirs anywhere, but we do have a problem currently where asgen only generates icons for one arch for us with this patch, do you happen to know why? |
|
Icons are shared between architectures... So, what don you mean they are only generated for one architecture? |
|
Oh, forgot to upstream a patch apparently. We need per architecture icons since some packages are disabled on certain architectures (e.g. if they don't build on one platform), would it be possible to enable that? For some reason our icon archives also only contain icons of packages that have been updated since the last run I'll try getting a verbose log later |
Same for Debian, but it's much cheaper on storage space and download size to just not make arch-specific icon tarballs, as 90% of all packages are available on all architectures, and just a tiny amount is arch-specific. And having more icons than needed doesn't hurt. |
|
The patch is Cogitri@65b82c7 - but if we could just generate icons for x86_64 then that would work for us as well. I guess by default asgen uses the last arch in the config as the arch it generates icons for? |
|
No, asgen will just pick the first architecture it encounters that has an icon. So if an icon appears in any of the selected architectures, it will be included. So, if x86_64 has all icons and aarch64 doesn't, you will still get an icon tarball with the union of the icons in both architecture sets. |
|
Ohhh, okay, that works, thanks for the explanation :) |
This is useful for e.g. exporting to a versioned
(by date) dir.
fixes #81