snap/ubuntu fixes #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximion
reviewed
Feb 12, 2021
ximion
force-pushed
the
master
branch
12 times, most recently
from
168fd1c
to
0bd88bf
Compare
|
Except for that nitpick, this looks good to me! It's very odd that these methods in DebPackage had no locking whatsoever - likely the package was only to be used from one thread originally, until we started hunting down icons all over the place. |
ximion
force-pushed
the
master
branch
2 times, most recently
from
8d66ee2
to
91300ad
Compare
iainlane
force-pushed
the
snap-ubuntu-fixes
branch
from
8bb97af
to
fc39344
Compare
added 4 commits
February 15, 2021 12:33
… temporary dir When downloading remote packages, we place them into a package specific temporary directory. This is so we can remove them once we think we're done, so that peak space usage is minimised. We decide if a package is downloaded or not by the 'local' filename being set. If it's set, we return this path to callers and then they can try to operate on it. The problem is, we were failing to clear this variable when removing the temporary directory in some circumstances. That was meaning that a stale path could be given out to callers, a path to a file that doesn't exist any more. Fix this by always clearing the local path when removing the temporary directory. That means that the next time the file is requested it will be re-downloaded if this is a remote path.
These operations are most thread unsafe; they are dealing with the underlying filesystem. Make sure they are synchronized.
libarchive stores errno with the actual cause of the error. Print it.
Newer versions of snapcraft seem to have changed the cwd of the build
step. It's more robust to do this by absolute path anyway, so do that.
A couple of parts of the build system want fixing for that-
- Run the tests from the root of the source tree, and
- Find data assets relative to the cwd
Another alternative would be to do something like
`G_TEST_{BUILD,SRC}DIR` that GLib has - environment variables that can
be defined to help tests find their assets. But this works OK for now.
Also run the sedding on the .gir file in override-pull; if the build
step is run twice then this results in messed up files otherwise.
iainlane
force-pushed
the
snap-ubuntu-fixes
branch
from
fc39344
to
7982722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hope it's ok to bundle these up...
Couple of things here