Apply suggestions from code review

Co-authored-by: Matthias Klumpp <matthias@tenstral.net>
ximion · Mar 3, 2023 · fddd8de · fddd8de
1 parent acf50d3
commit fddd8de
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/as-cache.c b/src/as-cache.c
@@ -2007,5 +2007,5 @@ as_cache_get_component_count (AsCache* cache)
 					  0,
 					  FALSE,
 					  &error);
-	return components->len > 0;
+	return components->len;
 }
diff --git a/src/as-pool.c b/src/as-pool.c
@@ -2889,10 +2889,10 @@ as_pool_set_load_std_data_locations (AsPool *pool, gboolean enabled)
 }
 
 gboolean
-as_pool_get_components_is_empty(AsPool* pool)
+as_pool_is_empty (AsPool* pool)
 {
 	AsPoolPrivate *priv = GET_PRIVATE (pool);
-	return as_cache_get_is_empty(priv->cache);
+	return as_cache_get_component_count (priv->cache) > 0;
 }
 
 /**

diff --git a/tests/test-pool.c b/tests/test-pool.c
@@ -486,7 +486,7 @@ test_pool_read (void)
 	g_assert_cmpstr (as_component_get_id (cpt_s), ==, "org.inkscape.Inkscape");
 	g_clear_pointer (&result, g_ptr_array_unref);
 
-	g_assert_false (as_pool_get_components_is_empty(dpool));
+	g_assert_false (as_pool_is_empty (dpool));
 }
 
 /**