New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel build problem with introspection #106
Comments
|
Full build log build.0.20170301091110.txt |
|
Unfortunately can't reproduce this problem (built from scratch with |
|
Hmm, can you maybe try whether this trivial changes help? --- a/data/cmake/GObjectIntrospectionMacros.cmake
+++ b/data/cmake/GObjectIntrospectionMacros.cmake
@@ -81,7 +81,7 @@ macro(gir_add_introspections introspections_girs)
--includedir=.
${CMAKE_CURRENT_BINARY_DIR}/${gir}
-o ${CMAKE_CURRENT_BINARY_DIR}/${_typelib}
- DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${gir}
+ DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${gir} ${gir}
OUTPUT ${_typelib}
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
)The dependencies look correct, but maybe by using an absolute path, cmake only check whether the file exists and not whether the previous command did actually finish to run. |
|
Reading https://samthursfield.wordpress.com/2015/11/21/cmake-dependencies-between-targets-and-files-and-custom-commands/#custom-commands-and-parallel-make it seems you need to depend both on the file and a custom_target |
|
maybe something like: Unfortunately I have failed to reproduce it since that one time it happened :( |
|
The code in question is used by a lot of people and projects, including things like e.g. Poppler, so I find it quite surprising that it fails at all, given the amount of testing it has received. |
|
Please reopen this in case it happens again (but it's likely I will use Meson for AppStream soonish anyway) |
We got a build failure where it tried generating the typelib from the gir before the gir was finished:
The text was updated successfully, but these errors were encountered: