Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to YAML removes screenshots? #131

Closed
probonopd opened this issue Aug 20, 2017 · 2 comments
Closed

Conversion to YAML removes screenshots? #131

probonopd opened this issue Aug 20, 2017 · 2 comments

Comments

@probonopd
Copy link

When converting this input file

...
    <screenshots>
        <screenshot type="default">http://images.videolan.org/vlc/screenshots/2.0.0/vlc-2.0-poney.jpg</screenshot>
        <screenshot type="default">http://images.videolan.org/vlc/screenshots/2.0.0/vlc-2.0-gnome3-open.jpg</screenshot>
        <screenshot type="default">http://images.videolan.org/vlc/screenshots/2.0.0/vlc-2.0-gnome3-debian.jpg</screenshot>
    </screenshots>
</component>

then I get this output file

...
Screenshots:
- default: true
  thumbnails: []
- default: true
  thumbnails: []
- default: true
thumbnails: []
me@host:~$ ./appstreamcli-x86_64.AppImage --version
AppStream CLI tool version: 0.11.4
@ximion
Copy link
Owner

ximion commented Aug 20, 2017

This is because the metainfo file is wrong(tm).

  • The <screenshot/> tags misses an <image/> child - validate even complains about that. There was some fallback code in AS, which doesn't appear to be working here (that might be a bug, I need to look into that - could also be that this was intentional).
  • Only one "default" screenshot is allowed. I should add a check for that to the validator.

@probonopd
Copy link
Author

Thanks. Note to self, never assume anything to be correct ;-)

This example was from
https://github.com/videolan/vlc/blob/master/share/vlc.appdata.xml.in.in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants