Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vala bindings reference non-existent header #136

Closed
rdieter opened this issue Sep 14, 2017 · 4 comments
Closed

vala bindings reference non-existent header #136

rdieter opened this issue Sep 14, 2017 · 4 comments

Comments

@rdieter
Copy link

rdieter commented Sep 14, 2017

In recent releases (maybe since meson buildsystem introduced?), there's an error in the vala bindings:

cheader_filename references a non-existent file name: AppStream-1.0.h (instead of appstream.h ?)

@ximion
Copy link
Owner

ximion commented Sep 14, 2017

Indeed! Previously, the header name was passed explicitly, now it seems to be inferred somehow, which is wrong.
Meson doesn't seem to have an option to set this yet, I'll have to look into this.

@decathorpe
Copy link

Thanks for filing the issue, I didn't yet have the time to report the bug myself ... I only noticed that the new appstream version broke builds of appcenter and slingshot on fedora, and I guess elementaryOS will hit the same problem eventually.

@ximion
Copy link
Owner

ximion commented Sep 14, 2017

I need to submit a patch to Meson to allow setting --c-include on GIR generation to fix this properly. Until then, I have committed a workaround.

ximion added a commit that referenced this issue Sep 14, 2017
@rdieter
Copy link
Author

rdieter commented Sep 14, 2017

Thanks, confirmed workaround works as advertised

@rdieter rdieter closed this as completed Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants