Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaks /etc/os-release fd to child processes #148

Closed
Vogtinator opened this issue Nov 18, 2017 · 1 comment
Closed

Leaks /etc/os-release fd to child processes #148

Vogtinator opened this issue Nov 18, 2017 · 1 comment
Labels

Comments

@Vogtinator
Copy link
Contributor

This library is often loaded into application launchers. However, once as_distro_details_new is called, the fd never gets closed as O_CLOEXEC is not set as flag.
For instance, open a terminal from krunner and you'll see that fd 23 of /proc/self/fd is valid and points to /etc/os-release.

@ximion ximion added the bug label Nov 23, 2017
@ximion
Copy link
Owner

ximion commented Nov 23, 2017

There is indeed a leak on the data input stream there (which I guess triggers this issue). Adjusting the flags might also be a good idea.

@ximion ximion closed this as completed in b8d8974 Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants