<image> URI validation

[hsitter]

appstreamcli validate apparently doesn't validate that are actually valid URIs

e.g. I recently saw an app dev forget to deal with a bit of boilerplate placeholder and leave the following in their appdata:

      <image>
        see https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots
        Central hosting for uploading at https://phabricator.kde.org/source/websites-product-screenshots/
        Central URL to use here https://cdn.kde.org/screenshots/...
      </image>

Would be handy if it ran the image through a URI parser.

[ximion]

This is actually implemented, unless you pass the --nonet flag to appstreamcli.
The only improvement I can imagine here would be to validate whether we have an URL at all even if nonet has been passed.

[hsitter]

That's without any flags appstreamcli validate org.kde.babe.appdata.xml

I've asked some people to test on newer versions but haven't heard back yet. On the 0.11.1 cli we have in neon the <image> did not cause a validation error.

I am posting the complete appdata so everyone can give it a try

<?xml version="1.0" encoding="utf-8"?>
<component type="desktop">
  <id>org.kde.babe.desktop</id>
  <metadata_license>CC0-1.0</metadata_license>
  <project_license>GPL-3.0</project_license>
  <name>Babe</name>
  <summary>Babe is a tiny music collection manager</summary>
  <description>
    <p> Babe will handle your whole music collection, letting you create custom playlists to organize your music. You can also filter your music by artist, title, album, genre, date and location. Babe let's you babe-mark your favorite YouTube music videos into your local collection by using the Chromium extension. Think of Babe as the playlist where all your favorite tracks at the moment are. And when needed you also have an integrated collection manager. </p>
    <p>Use the Chrome extension to collect your favorite music videos from online streaming services like YouTube or Vimeo. Babe uses youtube-dl, so all the supported sites by it are also supported by Babe</p>
    <p>Babe is built with a tight integration with the Plasma desktop, making use of native notifications, mpris controls, kde connect to send your music to your devices and also krunner action queries.</p>
    <ul>
      <li>this</li>
      <li>that</li>
    </ul>
  </description>
  <url type="homepage">https://babe.kde.org/</url>
  <url type="bugtracker">https://bugs.kde.org/enter_bug.cgi?format=guided&amp;product=babe</url>
  <url type="donation">https://www.kde.org/community/donations/?app=Babe</url>
  <screenshots>
    <screenshot type="default">
      <image>
        see https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots
        Central hosting for uploading at https://phabricator.kde.org/source/websites-product-screenshots/
        Central URL to use here https://cdn.kde.org/screenshots/...
      </image>
    </screenshot>
  </screenshots>
  <provides>
    <binary>babe</binary>
  </provides>
  <project_group>KDE</project_group>
</component>

[ximion]

@apachelogger You will need at least AppStream 0.11.7 to get URL testing working by default.

[hsitter]

Ah!
If the appdata doesn't pass validation with 0.11.7 I'm fine with closing the issue, sorry for the noise :)

[ximion]

Validation with 0.11.8:

P - org.kde.babe.xml:org.kde.babe.desktop:21
    The screenshot does not have a caption text.

W - org.kde.babe.xml:org.kde.babe.desktop:22
    Unable to reach screenshot image on remote location '
            see 
    https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots
            Central hosting for uploading at 
    https://phabricator.kde.org/source/websites-product-screenshots/
            Central URL to use here https://cdn.kde.org/screenshots/...
          ' - does the image exist?

Validation failed: warnings: 1, pedantic: 1

[hsitter]

Yay. Cheers!

[ximion]

I might add a regex-based validation as well though, at a later time :-)