Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsPool possible wrong check #178

Closed
tintou opened this issue Feb 25, 2018 · 1 comment
Closed

AsPool possible wrong check #178

tintou opened this issue Feb 25, 2018 · 1 comment

Comments

@tintou
Copy link
Contributor

tintou commented Feb 25, 2018

I think that there is something wrong in this line
https://github.com/ximion/appstream/blob/master/src/as-pool.c#L291

origin_kind of cpt was already checked a little bit earlier so I guess it's a typo and you want the origin_kind of existing_cpt
@ximion
Copy link
Owner

ximion commented Mar 5, 2018

Absolutely! Also, the commend in the following line is weird ;-)

@ximion ximion closed this as completed in b5bd018 Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ximion @tintou