Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide different DPI for the icons #21

Closed
tintou opened this issue Jan 15, 2016 · 3 comments
Closed

Provide different DPI for the icons #21

tintou opened this issue Jan 15, 2016 · 3 comments

Comments

@tintou
Copy link
Contributor

tintou commented Jan 15, 2016

Currently the specification doesn't mention anything related to DPI support.
It seems that people are wrongly using the 128px icons for the 64@2 icons but they are not the same icons.
Here are more explicit informations about this problem:
http://blog.elementary.io/post/124193007916/whats-up-with-hidpi-icons
To solve this problem i propose to allow a dpi property that way:

<icon type="remote" width="64" height="64">http://example.com/icons/foobar.png</icon>
<icon type="remote" width="64" height="64" dpi="2">http://example.com/icons/foobar@2.png</icon>

The default dpi value should be 1 so it's not mandatory to set it.

@ximion
Copy link
Owner

ximion commented Jul 19, 2016

We can probably have that with a scale property instead of dpi - but I don't know whether distributions would actually ship icons for 64x64, 64x64@2 and 128x128.
I could imagine for Debian to drop 128x128 and just ship the 64x64 icons and the scaled ones.
Downloading them in all sizes it quite a huge amount of data.

@ximion
Copy link
Owner

ximion commented Jul 23, 2016

Looks like KDE Discover will have an interest in this as well, soon.

@ximion
Copy link
Owner

ximion commented Apr 14, 2017

Please keep in mind that this is only part of the solution: The AppStream generator will need support for it too to generate another tarball with HiDPI icons, and to set the proper metadata.
With this, the initial work is done though and adding support to asgen isn't hard (and I plan to have it for the next release of it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants