Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.12.6 test failures on Ubuntu #222

Closed
jbicha opened this issue Mar 3, 2019 · 8 comments
Closed

0.12.6 test failures on Ubuntu #222

jbicha opened this issue Mar 3, 2019 · 8 comments

Comments

@jbicha
Copy link
Contributor

jbicha commented Mar 3, 2019

appstream 0.12.6 fails to build on Ubuntu because of test failures:

https://launchpad.net/ubuntu/+source/appstream/0.12.6-1
@ximion
Copy link
Owner

ximion commented Mar 3, 2019

Oh wow, what happened there? Nearly every test that reads or writes AppStream data failed.
The same code tests fine on the CI, and also ran fine on Debian during the build process.
The weirdest thing is that XML results are somehow suddenly showing YAML output and vice versa.

ximion added a commit that referenced this issue Mar 3, 2019
@ximion
tests: Fix potential wrong output when two tests fail in parallel
0307a51 
This should actually never ever happen, but just in case it does, we can
protect against this case a little.
The default behavior is that the comparison succeeds and we don't
actually need to invoke diff at all, so the extra allocations will not
slow down the tests.
CC: #222
@ximion
Copy link
Owner

ximion commented Mar 3, 2019

I've fixed a potential diff output confusion when tests fail in parallel, but that's not the cause of this problem here.
Can you reproduce the issue locally?

@jbicha
Copy link
Contributor Author

jbicha commented Mar 3, 2019

Yes, more specifically, it looks like the issue is triggered by glib 2.59.

@ximion
Copy link
Owner

ximion commented Mar 3, 2019

Hmm, from the changelog there at least is no super obvious change in GLib that could have triggered this.

@jbicha
Copy link
Contributor Author

jbicha commented Mar 3, 2019

Does this help?

https://gitlab.gnome.org/GNOME/tracker/commit/c58f7aa419e2

@ximion
Copy link
Owner

ximion commented Mar 3, 2019

Ah yeah, that change... - I was actually quite confident AppStream wasn't depending on GHashTable ordering, but that actually would explain the test failures.
I'll have to run the tests locally with a recent GLib though to find all the problems.

@robert-ancell
Copy link
Contributor

#223

@robert-ancell robert-ancell mentioned this issue Mar 22, 2019
Merged
@ximion
Copy link
Owner

ximion commented Jun 16, 2019

Those are fully fixed for a while now, and will soon be in a long overdue release.

@ximion ximion closed this as completed Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robert-ancell @ximion @jbicha