Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release date should accept all ISO 8601 dates #245

Closed
klausenbusk opened this issue Aug 12, 2019 · 1 comment
Closed

release date should accept all ISO 8601 dates #245

klausenbusk opened this issue Aug 12, 2019 · 1 comment

Comments

@klausenbusk
Copy link

appstream does not currently accept 2019-07 as a valid release date (<release> has no timestamp), but according to the spec it should be valid: The date property can have any time in ISO 8601 format as its value and should be present for every release.
klausenbusk added a commit to flathub/com.airtame.Client that referenced this issue Aug 12, 2019
@klausenbusk
appdata: Add day to release date
4d88728 
appstream won't accept a date without a day.
Bug: ximion/appstream#245
@ximion ximion closed this as completed in 3675e68 Aug 13, 2019
ximion added a commit that referenced this issue Aug 13, 2019
@ximion
validator: Validate release info better, check release dates
a8290f9 
This adds a few checks and cleanups for the release metadata, most
importantly validating the release dates for correctness.
See issue #245 for more information.
@ximion
Copy link
Owner

ximion commented Aug 13, 2019 •
edited

What the specification actually means here is that a ISO 8601 "complete date" is required, with at least by-day granularity. That means you need to have at least a year, month and day in there.
I clarified that in the specification, and also added a check for this to the validator, so appstreamcli validate will now throw a warning about this issue.
Your error message looks like you were using appstream-util from the appstream-glib project, which with this spec change is likely already fine and doesn't need a separate bug report.

Thank you for noticing and reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ximion @klausenbusk