Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppStream collection YAML #253

Closed
jakobjakobson13 opened this issue Sep 20, 2019 · 5 comments
Closed

AppStream collection YAML #253

jakobjakobson13 opened this issue Sep 20, 2019 · 5 comments
Labels

Comments

@jakobjakobson13
Copy link

Dear developers,

in a recent pull request the build of a flatpak image failed because the AppStream collection was saved as a yaml file and not as a json file.
Was this a bug in the configuration of their build workers or is AppStream just not able to handle AppStream collections in yaml formats even though the documentation says otherwise?

Regards

@TingPing
Copy link

TingPing commented Sep 20, 2019

Even if the tooling functions Flathub is not interested in using YAML for it.

Surely you realize a PR just blindly changing file formats with the comment "No tests have been done." is just... rude? Its a waste of everybodies time for useless churn.

(Ironically; Sorry for being off-topic here.)

@ximion
Copy link
Owner

ximion commented Sep 20, 2019

@jakobjakobson13 JSON is not used in AppStream at all anywhere, I guess you mean XML?
While a YAML version of AppStream exists and is fully supported and used by distributions like Debian and Ubuntu, it doesn't mean that a system or distribution can't limit what it ships.
Debian permits only the YAML version, while Fedora permits only the XML version in their archives.
The same applies for Flatpak: While the libappstream library will happily read YAML or XML with no problems, the system that is Flatpak is perfectly fine in restricting the format it supports to XML-only.
Does that clarify things?

@jakobjakobson13
Copy link
Author

Even if the tooling functions Flathub is not interested in using YAML for it.

Sorry, back in that pull request I had the impression that it was surprising that the yaml file did not work.

Surely you realize a PR just blindly changing file formats with the comment "No tests have been done." is just... rude? Its a waste of everybodies time for useless churn.

(Ironically; Sorry for being off-topic here.)

I get your point and I won't do it again. I just wanted to be cautious and emphasize that even the build process worked, I did not check the functionality of package on my pc. Soryy.

@jakobjakobson13
Copy link
Author

@jakobjakobson13 JSON is not used in AppStream at all anywhere, I guess you mean XML?
While a YAML version of AppStream exists and is fully supported and used by distributions like Debian and Ubuntu, it doesn't mean that a system or distribution can't limit what it ships.
Debian permits only the YAML version, while Fedora permits only the XML version in their archives.
The same applies for Flatpak: While the libappstream library will happily read YAML or XML with no problems, the system that is Flatpak is perfectly fine in restricting the format it supports to XML-only.
Does that clarify things?

Yes, thanks.

@TingPing
Copy link

Sorry, back in that pull request I had the impression that it was surprising that the yaml file did not work.

It was surprising YAML was a supported format at all I think. Anyway I didn't mean to come off too upset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants